Re: [patch, fortran] Really fix PR 56782

2013-04-19 Thread Mikael Morin
Le 17/04/2013 19:12, Thomas Koenig a écrit : OK if accompanied by a ChangeLog entry and my test cases, as well :-) This is what I have just committed. 4.8 will follow in a few days. Mikael Index: testsuite/gfortran.dg/array_constructor_45.f90

Re: [patch, fortran] Really fix PR 56782

2013-04-17 Thread Thomas Koenig
Hi Mikael, Attached is what I had in mind. And a testcase (the '|| expr-expr_type == EXPR_FUNCTION' in copy_walk_reduction_arg appeared wrong to me, and it was seemingly). Yes, you can also do it this way. OK if accompanied by a ChangeLog entry and my test cases, as well :-) Thomas

Re: [patch, fortran] Really fix PR 56782

2013-04-15 Thread Mikael Morin
Le 14/04/2013 16:21, Thomas Koenig a écrit : Hi Mikael, - (void) gfc_expr_walker (fcn, callback_reduction, NULL); why remove this? Because it is not needed, as the test case _46 shows. No need to run this twice, it doesn't get better :-) Indeed, that's right. gfc_internal_error

[patch, fortran] Really fix PR 56782

2013-04-14 Thread Thomas Koenig
Hello world, the attached patch completely fixes the regression, PR 56782. Regression-tested. OK for trunk and 4.8? Thomas 2013-04-14 Thomas Koenig tkoe...@gcc.gnu.org PR fortran/56782 * frontend-passes.c (copy_walk_reduction_arg): Do not call the

Re: [patch, fortran] Really fix PR 56782

2013-04-14 Thread Mikael Morin
Hello, Le 14/04/2013 11:57, Thomas Koenig a écrit : Hello world, the attached patch completely fixes the regression, PR 56782. typo: it's PR 56872 everywhere. Regression-tested. OK for trunk and 4.8? Thomas 2013-04-14 Thomas Koenig tkoe...@gcc.gnu.org PR

Re: [patch, fortran] Really fix PR 56782

2013-04-14 Thread Thomas Koenig
Hi Mikael, - (void) gfc_expr_walker (fcn, callback_reduction, NULL); why remove this? Because it is not needed, as the test case _46 shows. No need to run this twice, it doesn't get better :-) It is a leftover from when the callback function returned 1. gfc_internal_error (Illegal id