Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-12-04 Thread Thomas Schwinge
Hi Julian! On Mon, 3 Dec 2018 21:10:50 +, Julian Brown wrote: > On Fri, 30 Nov 2018 16:25:42 +0100 > Thomas Schwinge wrote: > > [...] > > I've made those changes in the attached, thank you. OK? Yes, thanks! Grüße Thomas > 2018-XX-YY James Norris > Cesar Philippidis >

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 16:25:42 +0100 Thomas Schwinge wrote: > In addition to your "(1" token sequence (and similar ones), I suppose > what these code paths in C and C++ are supposed to catch the "wait ()" > case (see line 149 of gcc/testsuite/c-c++-common/goacc/asyncwait-1.c). > > I suppose in C,

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-11-30 Thread Thomas Schwinge
Hi Julian! On Fri, 28 Sep 2018 14:17:42 +0100, Julian Brown wrote: > On Wed, 26 Sep 2018 14:08:37 -0700 > Cesar Philippidis wrote: > > > On 09/26/2018 12:50 PM, Joseph Myers wrote: > > > On Wed, 26 Sep 2018, Cesar Philippidis wrote: > > > > > >> Attached is an old patch which updated the C

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-11-29 Thread Joseph Myers
On Thu, 29 Nov 2018, Julian Brown wrote: > > But for C, it does not appear that c_parser_expr_list has a code path > > that can return a zero-length list at all. So, we can elide the > > diagnostic with no change to compiler behaviour. This patch does that, > > and also changes the C++

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-11-29 Thread Julian Brown
On Fri, 28 Sep 2018 14:17:42 +0100 Julian Brown wrote: > On Wed, 26 Sep 2018 14:08:37 -0700 > Cesar Philippidis wrote: > > > On 09/26/2018 12:50 PM, Joseph Myers wrote: > > > On Wed, 26 Sep 2018, Cesar Philippidis wrote: > > > > > >> Attached is an old patch which updated the C and C++

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-09-28 Thread Julian Brown
On Wed, 26 Sep 2018 14:08:37 -0700 Cesar Philippidis wrote: > On 09/26/2018 12:50 PM, Joseph Myers wrote: > > On Wed, 26 Sep 2018, Cesar Philippidis wrote: > > > >> Attached is an old patch which updated the C and C++ FEs to use > >> %<)%> for the right ')' symbol. It's mostly a cosmetic

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-09-26 Thread Cesar Philippidis
On 09/26/2018 12:50 PM, Joseph Myers wrote: > On Wed, 26 Sep 2018, Cesar Philippidis wrote: > >> Attached is an old patch which updated the C and C++ FEs to use %<)%> >> for the right ')' symbol. It's mostly a cosmetic change. All of the >> changes are self-contained to the OpenACC code path. >

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

2018-09-26 Thread Joseph Myers
On Wed, 26 Sep 2018, Cesar Philippidis wrote: > Attached is an old patch which updated the C and C++ FEs to use %<)%> > for the right ')' symbol. It's mostly a cosmetic change. All of the > changes are self-contained to the OpenACC code path. Why is the "before ')'" included in the call to

[patch,openacc] C, C++ OpenACC wait diagnostic change

2018-09-26 Thread Cesar Philippidis
Attached is an old patch which updated the C and C++ FEs to use %<)%> for the right ')' symbol. It's mostly a cosmetic change. All of the changes are self-contained to the OpenACC code path. Is this OK for trunk? I bootstrapped and regtested it for x86_64 Linux with nvptx offloading. Thanks,