Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-14 Thread Thomas König
Hi Bernhard, > Am 14.10.2019 um 11:58 schrieb Bernhard Reutner-Fischer > : > > On 14 October 2019 10:50:55 CEST, Jakub Jelinek wrote: >>> On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: >>>testsuite/ >>>* gfortran.dg/gomp/target-simd.f90: New. >> >> John Reporte in bugz

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-14 Thread Bernhard Reutner-Fischer
On 14 October 2019 10:50:55 CEST, Jakub Jelinek wrote: >On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: >> testsuite/ >> * gfortran.dg/gomp/target-simd.f90: New. > >John reported in bugzilla the testcase fails on hppa with an error that >looks like heap corruption, and ind

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-14 Thread Jakub Jelinek
On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: > testsuite/ > * gfortran.dg/gomp/target-simd.f90: New. John reported in bugzilla the testcase fails on hppa with an error that looks like heap corruption, and indeed, running the test under valgrind fails on x86_64-linux t

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-09 Thread Jakub Jelinek
On Wed, Oct 09, 2019 at 11:46:37AM +0200, Thomas Schwinge wrote: > On 2019-10-09T08:04:29+0200, Bernhard Reutner-Fischer > wrote: > > On 8 October 2019 14:12:47 CEST, Jakub Jelinek wrote: > >>On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: > >>> Seemingly, 'target simd' was forgot

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-09 Thread Thomas Schwinge
Hi! Tobias, if that's not inconvenient for you for any reson (which?), would you please adopt the habit of using the same text for a commit's first line in the log message (r276698: "Fortran - fix OpenMP 'target simd'), and the email's "Subject" line ("[Fortran] Actually permit OpenMP's 'target si

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-08 Thread Bernhard Reutner-Fischer
On 8 October 2019 14:12:47 CEST, Jakub Jelinek wrote: >On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: >> Seemingly, 'target simd' was forgotten – which yielded the error: >> "Unexpected !$OMP TARGET SIMD statement" >> >> OK for the trunk? >Ok, with moving the test to libgomp.for

[OG9][committed] was: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-08 Thread Tobias Burnus
Trunk (r276698): I have tested it with nvptx, it worked; hence, I moved it to libgomp as run-time test. OG9: I have also committed the patch to the OG9 / openacc-gcc-9 branch. (54fbada7d4d38e420efb5a10d39e03b02533b1e7) Thanks, Tobias On 10/8/19 2:12 PM, Jakub Jelinek wrote: On Tue, Oct 08,

Re: [patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-08 Thread Jakub Jelinek
On Tue, Oct 08, 2019 at 02:04:17PM +0200, Tobias Burnus wrote: > Seemingly, 'target simd' was forgotten – which yielded the error: > "Unexpected !$OMP TARGET SIMD statement" > > OK for the trunk? > > Tobias > > PS: The test case should also work as 'dg-do run' test, if it makes more > sense. (On

[patch][Fortran] Actually permit OpenMP's 'target simd'

2019-10-08 Thread Tobias Burnus
Seemingly, 'target simd' was forgotten – which yielded the error: "Unexpected !$OMP TARGET SIMD statement" OK for the trunk? Tobias PS: The test case should also work as 'dg-do run' test, if it makes more sense. (Only tested on a system w/o offloading, but I would test it with nvptx before co