Re: [patch][rfc] Clean up CFG dumping

2012-10-29 Thread H.J. Lu
On Mon, Jul 16, 2012 at 8:57 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, There are comments in basic-block.h that advise to update certain parts of the compiler if a new edge flag or basic block flag is added: -/* Always update the table in cfg.c dump_edge_info. */ and -

Re: [patch][rfc] Clean up CFG dumping

2012-07-18 Thread Tobias Burnus
Steven, I think your patch broke bootstrapping with Graphite enabled. Tobias PS: Possible patch, I haven't checked whether 0 makes sense or something else should be used. --- a/gcc/graphite-poly.c +++ b/gcc/graphite-poly.c @@ -675,3 +675,3 @@ print_pbb_body (FILE *file, poly_bb_p pbb, int

Re: [patch][rfc] Clean up CFG dumping

2012-07-18 Thread Steven Bosscher
On Wed, Jul 18, 2012 at 2:24 AM, H.J. Lu hjl.to...@gmail.com wrote: This caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54008 Yes, they failed in my testing, too. I must have been blind to overlook them... I received some comments in private about the new look of the dumps, that I'll be

Re: [patch][rfc] Clean up CFG dumping

2012-07-18 Thread Steven Bosscher
On Wed, Jul 18, 2012 at 9:00 AM, Tobias Burnus bur...@net-b.de wrote: Steven, I think your patch broke bootstrapping with Graphite enabled. Yes it did. That's twice in one week, because Graphite isn't enabled for builds on the compile farm. I'll see if I can install the necessary libraries on

Re: [patch][rfc] Clean up CFG dumping

2012-07-17 Thread Bernhard Reutner-Fischer
On Mon, Jul 16, 2012 at 09:55:30PM +0200, Steven Bosscher wrote: On Mon, Jul 16, 2012 at 5:57 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, There are comments in basic-block.h that advise to update certain parts of the compiler if a new edge flag or basic block flag is added: -/*

Re: [patch][rfc] Clean up CFG dumping

2012-07-17 Thread Richard Guenther
On Mon, Jul 16, 2012 at 9:55 PM, Steven Bosscher stevenb@gmail.com wrote: On Mon, Jul 16, 2012 at 5:57 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, There are comments in basic-block.h that advise to update certain parts of the compiler if a new edge flag or basic block flag

Re: [patch][rfc] Clean up CFG dumping

2012-07-17 Thread Steven Bosscher
On Tue, Jul 17, 2012 at 9:40 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: s/anem/name/g Good catch. * tree-cfg.c (gimple_can_merge_blocks_p): Use EDGE_COMPLEX. I take it you added EDGE_ABNORMAL_CALL on purpose? Yes. I don't think it matters in practice because such

Re: [patch][rfc] Clean up CFG dumping

2012-07-17 Thread H.J. Lu
On Mon, Jul 16, 2012 at 8:57 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, There are comments in basic-block.h that advise to update certain parts of the compiler if a new edge flag or basic block flag is added: -/* Always update the table in cfg.c dump_edge_info. */ and -

Re: [patch][rfc] Clean up CFG dumping

2012-07-16 Thread Steven Bosscher
On Mon, Jul 16, 2012 at 5:57 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, There are comments in basic-block.h that advise to update certain parts of the compiler if a new edge flag or basic block flag is added: -/* Always update the table in cfg.c dump_edge_info. */ and -