Re: [patch] Fix PR C++/90448

2021-03-09 Thread Jan Hubicka
> On Mon, Mar 8, 2021 at 6:19 PM Eric Botcazou wrote: > > > > Hi, > > > > this is a regression present on the mainline and 10 branch for architectures > > that pass all structure types by reference, e.g. 32-bit PowerPC or SPARC. > > > > Jakub posted a detailed analysis in the audit trail and this

Re: [patch] Fix PR C++/90448

2021-03-09 Thread Richard Biener via Gcc-patches
On Tue, Mar 9, 2021 at 10:18 AM Eric Botcazou wrote: > > > The whole point of thunks is that they do not require things like copying > > ... is this case somehow IPA-SRA/CPed in an odd way? Otherwise it seems > > like the passed through reference was mishandled on the GIMPLE level? > > Maybe,

Re: [patch] Fix PR C++/90448

2021-03-09 Thread Eric Botcazou
> The whole point of thunks is that they do not require things like copying > ... is this case somehow IPA-SRA/CPed in an odd way? Otherwise it seems > like the passed through reference was mishandled on the GIMPLE level? Maybe, but the change looks correct on its own and nobody has cared about

Re: [patch] Fix PR C++/90448

2021-03-09 Thread Richard Biener via Gcc-patches
On Mon, Mar 8, 2021 at 6:19 PM Eric Botcazou wrote: > > Hi, > > this is a regression present on the mainline and 10 branch for architectures > that pass all structure types by reference, e.g. 32-bit PowerPC or SPARC. > > Jakub posted a detailed analysis in the audit trail and this boils down to >

[patch] Fix PR C++/90448

2021-03-08 Thread Eric Botcazou
Hi, this is a regression present on the mainline and 10 branch for architectures that pass all structure types by reference, e.g. 32-bit PowerPC or SPARC. Jakub posted a detailed analysis in the audit trail and this boils down to the RTL expander trying to take the address of a DECL whose RTX is