Re: [patch] Fix PR101188 wrong code from postreload

2023-06-10 Thread Jeff Law via Gcc-patches
On 6/3/23 12:38, Georg-Johann Lay wrote:     }   note_stores (insn, move2add_note_store, insn); The point is that in the continue block, the effect of the insn is recorded even if !success, it's just the computed effect of the code. Moreover, "next" is REG = REG + CONST_INT, so the

Re: [patch] Fix PR101188 wrong code from postreload

2023-06-05 Thread Jeff Law via Gcc-patches
On 6/5/23 09:06, Georg-Johann Lay wrote: Am 03.06.23 um 17:53 schrieb Jeff Law: On 6/2/23 02:46, Georg-Johann Lay wrote: There is the following bug in postreload that can be traced back to v5 at least: In postreload.cc::reload_cse_move2add() there is a loop over all insns.  If it encoun

Re: [patch] Fix PR101188 wrong code from postreload

2023-06-05 Thread Georg-Johann Lay
Am 03.06.23 um 17:53 schrieb Jeff Law: On 6/2/23 02:46, Georg-Johann Lay wrote: There is the following bug in postreload that can be traced back to v5 at least: In postreload.cc::reload_cse_move2add() there is a loop over all insns.  If it encounters a SET, the next insn is analyzed if it

Re: [patch] Fix PR101188 wrong code from postreload

2023-06-03 Thread Georg-Johann Lay
Am 03.06.23 um 17:53 schrieb Jeff Law: On 6/2/23 02:46, Georg-Johann Lay wrote: There is the following bug in postreload that can be traced back to v5 at least: In postreload.cc::reload_cse_move2add() there is a loop over all insns.  If it encounters a SET, the next insn is analyzed if it

Re: [patch] Fix PR101188 wrong code from postreload

2023-06-03 Thread Jeff Law via Gcc-patches
On 6/2/23 02:46, Georg-Johann Lay wrote: There is the following bug in postreload that can be traced back to v5 at least: In postreload.cc::reload_cse_move2add() there is a loop over all insns.  If it encounters a SET, the next insn is analyzed if it is a single_set. After next has been anal

[patch] Fix PR101188 wrong code from postreload

2023-06-02 Thread Georg-Johann Lay
There is the following bug in postreload that can be traced back to v5 at least: In postreload.cc::reload_cse_move2add() there is a loop over all insns. If it encounters a SET, the next insn is analyzed if it is a single_set. After next has been analyzed, it continues with if (success)