On Thu, Sep 13, 2012 at 2:29 PM, Jan Hubicka wrote:
> +/* Get the set of nodes for the cycle in the reduced call graph starting
> + from NODE. */
> +
> +VEC (cgraph_node_p, heap) *
> +ipa_get_nodes_in_cycle (struct cgraph_node *node)
>
> I never really like the api of SCC searching that made us
On Thu, Sep 13, 2012 at 3:08 PM, Steven Bosscher wrote:
>> +/* Compute X &= Y, taking into account the possibility that
>> + X may become the maximum set. */
>>
>> Hmm, how can X become the maximum set if it was not the maximum set
>> before? Thus, shouldn't this simply be
>>
>> if (y == all
> +/* Compute X &= Y, taking into account the possibility that
> + X may become the maximum set. */
>
> Hmm, how can X become the maximum set if it was not the maximum set
> before? Thus, shouldn't this simply be
>
> if (y == all_module_statics)
>/* do nothing */;
> else
> ...
>
> ?
No.
> Hello,
>
> This patch cleans up some things that annoyed me in ipa-reference.c
> and ipa-pure-const.c. These two passes are very important but they
> show all the signs of being developed when GCC's IPA infrastructure
> was still (or at least even more than today) in its infancy: Walking
yeah,
On Wed, Sep 12, 2012 at 8:27 PM, Steven Bosscher wrote:
> Hello,
>
> This patch cleans up some things that annoyed me in ipa-reference.c
> and ipa-pure-const.c. These two passes are very important but they
> show all the signs of being developed when GCC's IPA infrastructure
> was still (or at lea