Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-16 Thread Eric Botcazou
> Sure, if that works it's pre-approved. Your original patch is also ok > (though I still > think it's incomplete - but we'll wait until a testcase comes up with > the assert). It passed a bootstrap/regtest cycle on x86-64/Linux so I have installed it. 2015-10-16 Eric Botcazou * tre

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-16 Thread Richard Biener
On Fri, Oct 16, 2015 at 9:48 AM, Eric Botcazou wrote: >> Btw, would be really nice to have libbacktrace support for ada ... > > OK, I'll keep that in mind. > >> While the patch looks technically ok I think you'll run into the same issue >> with a non-zero offset MEM_REF as that will get you a POIN

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-16 Thread Eric Botcazou
> Btw, would be really nice to have libbacktrace support for ada ... OK, I'll keep that in mind. > While the patch looks technically ok I think you'll run into the same issue > with a non-zero offset MEM_REF as that will get you a POINTER_PLUS_EXPR > from build_fold_addr_expr. We might be lucky

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-15 Thread Richard Biener
On Wed, Oct 14, 2015 at 5:59 PM, Eric Botcazou wrote: > Hi, > > this is the regression of ACATS c37213k at -O2 with an upcoming change in > the front-end of the Ada compiler: > > eric@polaris:~/gnat/gnat-head/native> gcc/gnat1 -quiet c37213k.adb -I > /home/eric/gnat/bugs/support -O2 > +===

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-14 Thread Jeff Law
On 10/14/2015 02:57 PM, Eric Botcazou wrote: Can you use the TMR_OFFSET macro rather than TREE_OPERAND (op0, 1)? It also seems that you need a stronger check here. Essentially you have to verify that STEP * INDEX + INDEX2 + OFFSET == 0 Right? No, it's MEM_REF, not TARGET_MEM_REF, see build_f

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-14 Thread Eric Botcazou
> Can you use the TMR_OFFSET macro rather than TREE_OPERAND (op0, 1)? > > It also seems that you need a stronger check here. > > Essentially you have to verify that > STEP * INDEX + INDEX2 + OFFSET == 0 > > Right? No, it's MEM_REF, not TARGET_MEM_REF, see build_fold_addr_expr_with_type_loc. --

Re: [patch] Minor adjustment to gimplify_addr_expr

2015-10-14 Thread Jeff Law
On 10/14/2015 09:59 AM, Eric Botcazou wrote: Hi, this is the regression of ACATS c37213k at -O2 with an upcoming change in the front-end of the Ada compiler: eric@polaris:~/gnat/gnat-head/native> gcc/gnat1 -quiet c37213k.adb -I /home/eric/gnat/bugs/support -O2 +===GNAT B

[patch] Minor adjustment to gimplify_addr_expr

2015-10-14 Thread Eric Botcazou
Hi, this is the regression of ACATS c37213k at -O2 with an upcoming change in the front-end of the Ada compiler: eric@polaris:~/gnat/gnat-head/native> gcc/gnat1 -quiet c37213k.adb -I /home/eric/gnat/bugs/support -O2 +===GNAT BUG DETECTED==+ |