Re: [patch] Why xstrdup cgraph node names for dumpfiles?

2014-08-27 Thread Jan Hubicka
> On Tue, Aug 26, 2014 at 10:52 PM, Uros Bizjak wrote: > > Hello! > > > >> I noticed most of the cgraph and IPA files use xstrdup for cgraph node > >> names when printing to dump_file. Very leaky... > >> > >> What is the reason for all those xstrdups? I couldn't think of any. > > > > Please see [1]

Re: [patch] Why xstrdup cgraph node names for dumpfiles?

2014-08-26 Thread Steven Bosscher
On Tue, Aug 26, 2014 at 10:52 PM, Uros Bizjak wrote: > Hello! > >> I noticed most of the cgraph and IPA files use xstrdup for cgraph node >> names when printing to dump_file. Very leaky... >> >> What is the reason for all those xstrdups? I couldn't think of any. > > Please see [1] and [2]. > > [1]

Re: [patch] Why xstrdup cgraph node names for dumpfiles?

2014-08-26 Thread Uros Bizjak
Hello! > I noticed most of the cgraph and IPA files use xstrdup for cgraph node > names when printing to dump_file. Very leaky... > > What is the reason for all those xstrdups? I couldn't think of any. Please see [1] and [2]. [1] https://gcc.gnu.org/ml/gcc-patches/2012-04/msg01904.html [2] https

[patch] Why xstrdup cgraph node names for dumpfiles?

2014-08-26 Thread Steven Bosscher
Hello Martin, Honza, I noticed most of the cgraph and IPA files use xstrdup for cgraph node names when printing to dump_file. Very leaky... What is the reason for all those xstrdups? I couldn't think of any. Thoughts? Ciao! Steven * cgraph.c (cgraph_node::get_create): Don't xstrdup cgr