Re: [patch] improve internals documentation for nested function descriptors

2018-08-06 Thread Eric Botcazou
> Here's another attempt at documenting what's there now, this time > avoiding using the ambiguous term "custom" at all in the text. I've > also tried to address the other comments. Is this any better? Yes, it's fine with me, thanks. -- Eric Botcazou

Re: [patch] improve internals documentation for nested function descriptors

2018-08-05 Thread Sandra Loosemore
On 08/03/2018 12:16 PM, Jeff Law wrote: On 07/27/2018 03:44 PM, Eric Botcazou wrote: Apropos of the discussion about improving the docs for TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port submission, https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html here is the

Re: [patch] improve internals documentation for nested function descriptors

2018-08-03 Thread Jeff Law
On 07/27/2018 03:44 PM, Eric Botcazou wrote: >> Apropos of the discussion about improving the docs for >> TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port >> submission, >> >> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html >> >> here is the patch I've come up with

Re: [patch] improve internals documentation for nested function descriptors

2018-07-28 Thread Eric Botcazou
> This is precisely what I found so confusing about the original text. To > me, "custom" implies that the back end is *customized* to have its own > descriptor implementation to conform to target-specific ABI standards, > not that it uses a generic implementation in common code. To me, "custom"

Re: [patch] improve internals documentation for nested function descriptors

2018-07-27 Thread Sandra Loosemore
On 07/27/2018 03:44 PM, Eric Botcazou wrote: Apropos of the discussion about improving the docs for TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port submission, https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html here is the patch I've come up with based on reading the

Re: [patch] improve internals documentation for nested function descriptors

2018-07-27 Thread Eric Botcazou
> Apropos of the discussion about improving the docs for > TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port > submission, > > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html > > here is the patch I've come up with based on reading the source. Is > this technically

Re: [patch] improve internals documentation for nested function descriptors

2018-07-27 Thread Paul Koning
> On Jul 27, 2018, at 4:39 PM, Sandra Loosemore wrote: > > Apropos of the discussion about improving the docs for > TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port > submission, > > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html > > here is the patch I've

[patch] improve internals documentation for nested function descriptors

2018-07-27 Thread Sandra Loosemore
Apropos of the discussion about improving the docs for TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port submission, https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html here is the patch I've come up with based on reading the source. Is this technically accurate? Any