On 3 July 2013 05:15, Tim Shen wrote:
All fixed. I use `_RegexMask` rather than `const _RegexMask` just
because, IMO, const reference is for something very large and doesn't
need to be every-byte-accessed.
Add _RegexMask::_S_valid_mask = 0x3 instead of using the literal everywhere.
Sorry for
On Tue, Jul 9, 2013 at 4:35 PM, Jonathan Wakely jwakely@gmail.com wrote:
Sorry for the delay, I missed this latest version - it looks excellent
and is fine to commit. Do you have svn write access or do you need
someone to commit it for you?
I don't have svn write access. Should I make a
On 9 July 2013 11:13, Tim Shen wrote:
On Tue, Jul 9, 2013 at 4:35 PM, Jonathan Wakely jwakely@gmail.com wrote:
Sorry for the delay, I missed this latest version - it looks excellent
and is fine to commit. Do you have svn write access or do you need
someone to commit it for you?
I don't
On 07/09/2013 06:17 AM, Jonathan Wakely wrote:
On 9 July 2013 11:13, Tim Shen wrote:
On Tue, Jul 9, 2013 at 4:35 PM, Jonathan Wakely jwakely@gmail.com wrote:
Sorry for the delay, I missed this latest version - it looks excellent
and is fine to commit. Do you have svn write access or do you
On 30 June 2013 08:55, Tim Shen wrote:
ChangeLog entry fixed.
Some comments on the latest patch (it's a long-ish email but most of
my comments are very minor things regarding the _RegexMask type) ...
Defining struct _RegexMask in the typedef declaration makes it public,
I think I would prefer
On Wed, Jul 3, 2013 at 1:11 AM, Jonathan Wakely jwakely@gmail.com wrote:
Defining struct _RegexMask in the typedef declaration makes it public,
I think I would prefer if the struct definition was a private member
of regex_traits and only the char_class_type typedef was public.
Either that
Forgot the patch file .
--
Tim Shen
regex_traits.patch
Description: Binary data
Hi,
Second, making it `const` enables more potential compiler
optimizations.
Stylistically, we already discussed this in the past and the outcome was that
normally we don't use const by value anywhere. But personally I don't have a
strong opinion and certainly I would not object if it makes
On 2 July 2013 20:27, Paolo Carlini wrote:
Hi,
Second, making it `const` enables more potential compiler
optimizations.
Stylistically, we already discussed this in the past and the outcome was that
normally we don't use const by value anywhere. But personally I don't have a
strong
On 2 July 2013 20:10, Tim Shen wrote:
On Wed, Jul 3, 2013 at 1:11 AM, Jonathan Wakely jwakely@gmail.com wrote:
I think the _RegexMask constructor should be explicit.
I intentionally make _RegexMask act like an unsigned number. Since
lookup_collatename is required to return a value
All fixed. I use `_RegexMask` rather than `const _RegexMask` just
because, IMO, const reference is for something very large and doesn't
need to be every-byte-accessed.
Add _RegexMask::_S_valid_mask = 0x3 instead of using the literal everywhere.
--
Tim Shen
regex_traits.patch
Description:
On Sat, Jun 29, 2013 at 2:39 PM, Paolo Carlini paolo.carl...@oracle.com wrote:
Ah, now I see, Catherine told me you would mentor it. Excellent. Then please
properly format the code, adjust the ChangeLog entry (no libstdc++ at the
beginning of each line because the svn diff is invoked inside
Thank you for response!
On Sat, Jun 29, 2013 at 7:08 AM, Paolo Carlini paolo.carl...@oracle.com wrote:
Very nice to see progress in this area! Obvious question - I may have missed
past discussions: is your paperwork, the copyright assignment, Ok?
Otherwise, unfortunately, the technical review
On 29 June 2013 08:16, Tim Shen wrote:
Thank you for response!
On Sat, Jun 29, 2013 at 7:08 AM, Paolo Carlini paolo.carl...@oracle.com
wrote:
Very nice to see progress in this area! Obvious question - I may have missed
past discussions: is your paperwork, the copyright assignment, Ok?
On 06/28/2013 05:47 AM, Tim Shen wrote:
Here is an all-in-one patch of implementing std::regex_traits in
libstdc++-v3, including testsuites.
Very nice to see progress in this area! Obvious question - I may have
missed past discussions: is your paperwork, the copyright assignment,
Ok?
Here is an all-in-one patch of implementing std::regex_traits in
libstdc++-v3, including testsuites.
This patch also includes changes in
http://gcc.gnu.org/ml/libstdc++/2013-04/msg00115.html, so just forget
that one.
Thank you!
--
Tim Shen
regex_traits.patch
Description: Binary data
16 matches
Mail list logo