Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-22 Thread Eric Botcazou
My apologies for the delay on Ada. I have reworked the patch to leave the first pass on the TYPE_DECLs which are definitely needed. I also optimized things a bit, since we don't need to save all the globals any more. Thanks, this looks fine modulo a couple of nits, see below. There is one

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-22 Thread Aldy Hernandez
On 05/22/2015 04:31 AM, Eric Botcazou wrote: My apologies for the delay on Ada. I have reworked the patch to leave the first pass on the TYPE_DECLs which are definitely needed. I also optimized things a bit, since we don't need to save all the globals any more. Thanks, this looks fine modulo

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-21 Thread Aldy Hernandez
On 05/08/2015 06:26 AM, Eric Botcazou wrote: [Jason, question below.] What's the replacement mechanism for the first pass on global_decls? The comment explains that generating debug info must be delayed in this case. My apologies for the delay on Ada. I have reworked the patch to leave

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-09 Thread Eric Botcazou
My question exactly. Perhaps that was my confusion. Why is this using -global_decl? Because that's equivalent to -type_decl (iter, false) in DWARF. For example, the C front-end uses rest_of_type_compilation (see finish_struct() in c/c-decl.c) which calls -type_decl(), or it calls

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-09 Thread Eric Botcazou
Ah, I see what you mean. I'll address this and repost. Thanks. Did the first version pass the GDB testsuite? I thought we had a testcase exercising the pointer to Taft amendment type case in it. -- Eric Botcazou

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Eric Botcazou
@@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This - ensures that global types whose compilation hasn't been finalized yet, -

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 12:26 PM, Eric Botcazou ebotca...@adacore.com wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This -

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 03:35 AM, Richard Biener wrote: On Fri, May 8, 2015 at 12:26 PM, Eric Botcazou ebotca...@adacore.com wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 03:26 AM, Eric Botcazou wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This - ensures that global types

[patch 1/10] debug-early merge: Ada front-end

2015-05-07 Thread Aldy Hernandez
gcc/ada/ * gcc-interface/gigi.h (note_types_used_by_globals): New prototype. * gcc-interface/misc.c (gnat_parse_file): Call note_types_used_by_globals. * gcc-interface/utils.c: Remove global_decls. (gnat_pushdecl): Remove use of global_decls. (gnat_write_global_declarations): Rename to