Re: [ping] Fix PR debug/66728

On Nov 6, 2015, at 5:06 AM, Richard Biener wrote: >> If there are no substantial reasons to not check it in now, I’d like to >> proceed and get it checked in. People can refine it further in tree if they >> want. Any objections? > > Ok with a changelog entry and

Re: [ping] Fix PR debug/66728

On Fri, Nov 6, 2015 at 2:34 AM, Mike Stump wrote: > On Nov 5, 2015, at 4:32 AM, Richard Biener wrote: >> No idea on location lists but maybe this means we should just use the >> maximum supported integer mode for CONST_WIDE_INTs? > > Ah, yeah,

Re: [ping] Fix PR debug/66728

On Thu, Nov 5, 2015 at 12:45 AM, Mike Stump wrote: > > On Nov 4, 2015, at 12:50 PM, Richard Sandiford > wrote: > >> Mike Stump writes: >>> Index: dwarf2out.c >>>

Re: [ping] Fix PR debug/66728

On Nov 5, 2015, at 4:32 AM, Richard Biener wrote: > No idea on location lists but maybe this means we should just use the > maximum supported integer mode for CONST_WIDE_INTs? Ah, yeah, that sounds like a fine idea. Below is that version. I snuck in one more

Re: [ping] Fix PR debug/66728

Mike Stump writes: > Index: dwarf2out.c > === > --- dwarf2out.c (revision 229720) > +++ dwarf2out.c (working copy) > @@ -15593,8 +15593,13 @@ >return true; > > case CONST_WIDE_INT: >

Re: [ping] Fix PR debug/66728

On Nov 4, 2015, at 12:50 PM, Richard Sandiford wrote: > Mike Stump writes: >> Index: dwarf2out.c >> === >> --- dwarf2out.c (revision 229720) >> +++ dwarf2out.c (working

Re: [ping] Fix PR debug/66728

On Nov 4, 2015, at 4:15 AM, Richard Biener wrote: > I wonder if we'll manage to to get mode_for_size return BLKmode > in case of an original mode that was not of a size multiple of > HOST_BITS_PER_WIDE_INT (and that's host dependent even…). > We probably should use

Re: [ping] Fix PR debug/66728

On Wed, Nov 4, 2015 at 12:57 PM, Mike Stump wrote: > On Nov 4, 2015, at 1:43 AM, Richard Biener wrote: >> I think you should limit the effect of this patch to the dwarf2out use >> as the above doesn't make sense to me. > > Since dwarf is so

Re: [ping] Fix PR debug/66728

On Nov 4, 2015, at 1:43 AM, Richard Biener wrote: > I think you should limit the effect of this patch to the dwarf2out use > as the above doesn't make sense to me. Since dwarf is so special, and since other clients already do something sort of like this anyway, it

Re: [ping] Fix PR debug/66728

On Tue, Nov 3, 2015 at 10:58 PM, Mike Stump wrote: > On Nov 3, 2015, at 12:46 AM, Richard Sandiford > wrote: >> This isn't just an argument about the DWARF standard though. It's an >> argument about GCC internals. Presumably these hypothetical

Re: [ping] Fix PR debug/66728

Mike Stump writes: > On Nov 2, 2015, at 12:55 PM, Richard Sandiford > wrote: >> This was: >> >> ... Sometimes structure decls >> have BLKmode but are assigned an integer-mode rtl (e.g. when passing >> 3-byte structures by value to functions).

Re: [ping] Fix PR debug/66728

On Nov 3, 2015, at 12:46 AM, Richard Sandiford wrote: > This isn't just an argument about the DWARF standard though. It's an > argument about GCC internals. Presumably these hypothetical BLKmode > types would need to support addition, I don’t recall seeing that as a

Re: [ping] Fix PR debug/66728

On Nov 2, 2015, at 8:29 AM, Richard Sandiford wrote: > switch (GET_CODE (rtl)) > { > case CONST_INT: > - { > - HOST_WIDE_INT val = INTVAL (rtl); > + if (mode != BLKmode) This changes BLKmode for CONST_INT, but I didn’t see this discussed. I

Re: [ping] Fix PR debug/66728

Mike Stump writes: > On Nov 2, 2015, at 8:29 AM, Richard Sandiford > wrote: >> switch (GET_CODE (rtl)) >> { >> case CONST_INT: >> - { >> -HOST_WIDE_INT val = INTVAL (rtl); >> + if (mode != BLKmode) > > This changes

Re: [ping] Fix PR debug/66728

On Nov 2, 2015, at 12:55 PM, Richard Sandiford wrote: > This was: > > ... Sometimes structure decls > have BLKmode but are assigned an integer-mode rtl (e.g. when passing > 3-byte structures by value to functions). > [...] > loc_descriptor refuses to use