Re: [pph] Fix var order when streaming in. (issue4635074)

2011-06-28 Thread gchare
On 2011/06/28 11:27:56, Diego Novillo wrote: http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c#newcode1144 gcc/cp/pph-streamer-in.c:1144: /* The chains are built ba

Re: [pph] Fix var order when streaming in. (issue4635074)

2011-06-28 Thread dnovillo
http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c#newcode1144 gcc/cp/pph-streamer-in.c:1144: /* The chains are built backwards (ref: add_decl_to_level@name-lookup.c),

Re: [pph] Fix var order when streaming in. (issue4635074)

2011-06-28 Thread dnovillo
On 2011/06/28 00:27:04, Gabriel Charette wrote: The names and namespaces chains are built by adding each new element to the front of the list. When streaming it in we traverse the list of names and re-add them to the current chains; thus reversing the order in which they were defined in the

[pph] Fix var order when streaming in. (issue4635074)

2011-06-27 Thread Gabriel Charette
The names and namespaces chains are built by adding each new element to the front of the list. When streaming it in we traverse the list of names and re-add them to the current chains; thus reversing the order in which they were defined in the header file. Since this is a singly linked-list we