On Wed, Sep 28, 2011 at 5:31 PM, Diego Novillo wrote:
> On Wed, Sep 28, 2011 at 17:23, Gabriel Charette wrote:
>> More comments to come on [3/3], for now just a single comment below on
>> this specific patch:
>>
>>> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
>>> index 0bd4d6
On Wed, Sep 28, 2011 at 17:23, Gabriel Charette wrote:
> More comments to come on [3/3], for now just a single comment below on
> this specific patch:
>
>> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
>> index 0bd4d64..b267833 100644
>> --- a/gcc/cp/pph-streamer-in.c
>> +++ b/g
More comments to come on [3/3], for now just a single comment below on
this specific patch:
> diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
> index 0bd4d64..b267833 100644
> --- a/gcc/cp/pph-streamer-in.c
> +++ b/gcc/cp/pph-streamer-in.c
> @@ -439,7 +439,10 @@ pph_in_cxx_binding
The second patch re-factors pph_cache_get to remove the cache
selection logic into a separate function. I needed this to implement
pph_cache_sign in terms of pph_cache_get. Before this, pph_cache_get
tried to decide what cache to use. After this patch, a separate
pph_cache_select() function mak
