Re: [v3 PATCH] Implement LWG 2733 and LWG 2759

2017-11-14 Thread Jonathan Wakely
On 14/11/17 19:51 +0200, Ville Voutilainen wrote: On 14 November 2017 at 19:06, Jonathan Wakely wrote: Both files can use remove_cv_t instead of remove_cv::type (and there's no need to std-qualify it in std::gcd). They could also use is_integral_v and is_same_v but that's pre-existing, and les

Re: [v3 PATCH] Implement LWG 2733 and LWG 2759

2017-11-14 Thread Ville Voutilainen
On 14 November 2017 at 19:06, Jonathan Wakely wrote: > Both files can use remove_cv_t instead of remove_cv::type (and there's > no need to std-qualify it in std::gcd). > > They could also use is_integral_v and is_same_v but that's > pre-existing, and less important because there's no 'typename' th

Re: [v3 PATCH] Implement LWG 2733 and LWG 2759

2017-11-14 Thread Jonathan Wakely
On 14/11/17 18:14 +0200, Ville Voutilainen wrote: Implement LWG 2733 and LWG 2759 * include/experimental/numeric (gcd): Reject cv-qualified bool. (lcm): Likewise. * include/std/numeric (gcd): Likewise. (lcm): Likewise. * testsuite/26_numerics/gcd/gcd_neg.cc: Add tests and adjust

[v3 PATCH] Implement LWG 2733 and LWG 2759

2017-11-14 Thread Ville Voutilainen
Tested on Linux-x64. 2017-11-14 Ville Voutilainen Implement LWG 2733 and LWG 2759 * include/experimental/numeric (gcd): Reject cv-qualified bool. (lcm): Likewise. * include/std/numeric (gcd): Likewise. (lcm): Likewise. * testsuite/26_numerics/gcd/gcd_neg.cc: Add tests a