Re: [v3 PATCH] Implement std::is_aggregate.

2017-04-03 Thread Jonathan Wakely
On 02/04/17 15:08 +0300, Ville Voutilainen wrote: Implement std::is_aggregate. * include/std/type_traits (is_aggregate, is_aggregate_v): New. * testsuite/20_util/is_aggregate/requirements/explicit_instantiation.cc: New. * testsuite/20_util/is_aggregate/requirements/typedefs.cc: Lik

Re: [v3 PATCH] Implement std::is_aggregate.

2017-04-02 Thread Ville Voutilainen
On 2 April 2017 at 14:08, Jakub Jelinek wrote: > On Sun, Apr 02, 2017 at 12:24:16PM +0300, Ville Voutilainen wrote: >> On 2 April 2017 at 08:35, Jakub Jelinek wrote: >> >> + remove_cv_t<_Tp> >> >> + )> >> > >> > Any reason for the wrapping? >> >> No, it's just a result of a nocturnal co

Re: [v3 PATCH] Implement std::is_aggregate.

2017-04-02 Thread Jakub Jelinek
On Sun, Apr 02, 2017 at 12:24:16PM +0300, Ville Voutilainen wrote: > On 2 April 2017 at 08:35, Jakub Jelinek wrote: > >> + remove_cv_t<_Tp> > >> + )> > > > > Any reason for the wrapping? > > No, it's just a result of a nocturnal copy-paste-job of the existing > code for has_unique_objec

Re: [v3 PATCH] Implement std::is_aggregate.

2017-04-02 Thread Ville Voutilainen
On 2 April 2017 at 08:35, Jakub Jelinek wrote: >> + remove_cv_t<_Tp> >> + )> > > Any reason for the wrapping? No, it's just a result of a nocturnal copy-paste-job of the existing code for has_unique_object_representations. > Also, shouldn't there be also: > > /// is_aggregate_v > t

Re: [v3 PATCH] Implement std::is_aggregate.

2017-04-01 Thread Jakub Jelinek
On Sun, Apr 02, 2017 at 01:18:58AM +0300, Ville Voutilainen wrote: > Tested on Linux-x64. > > 2017-04-02 Ville Voutilainen > > Implement std::is_aggregate. > * include/std/type_traits (is_aggregate): New. > * testsuite/20_util/is_aggregate/requirements/explicit_instantiation.cc: >

[v3 PATCH] Implement std::is_aggregate.

2017-04-01 Thread Ville Voutilainen
Tested on Linux-x64. 2017-04-02 Ville Voutilainen Implement std::is_aggregate. * include/std/type_traits (is_aggregate): New. * testsuite/20_util/is_aggregate/requirements/explicit_instantiation.cc: New. * testsuite/20_util/is_aggregate/requirements/typedefs.cc: Likewise.