[x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-30 Thread Yuri Rumyantsev
Hi All! Second patch enables several Silvermont uarch features which improve performance of the new processor (based on experiments on real SLM hardware): 1. If using a 2-source or 3-source LEA for non-destructive destination purposes, or due to wanting ability to use SCALE, the use of LEA is

[x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-30 Thread Yuri Rumyantsev
Hi All Second patch enables several Silvermont uarch features which improve performance of the new processor (based on experiments on real SLM hardware): 1. If using a 2-source or 3-source LEA for non-destructive destination purposes, or due to wanting ability to use SCALE, the use of LEA is prefe

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-30 Thread Uros Bizjak
On Thu, May 30, 2013 at 4:25 PM, Yuri Rumyantsev wrote: > Hi All > > Second patch enables several Silvermont uarch features which improve > performance of the new processor (based on experiments on real SLM > hardware): > 1. If using a 2-source or 3-source LEA for non-destructive destination > pur

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Igor Zamyatin
We do want to use the same register for float_extend. On Thu, May 30, 2013 at 9:22 PM, Uros Bizjak wrote: > On Thu, May 30, 2013 at 4:25 PM, Yuri Rumyantsev wrote: >> Hi All >> >> Second patch enables several Silvermont uarch features which improve >> performance of the new processor (based on e

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Uros Bizjak
On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin wrote: > We do want to use the same register for float_extend. OK then. Please add a comment for this fact and also, please put single-line preparation statements inside double-quotes instead of curved braces. Uros. > On Thu, May 30, 2013 at 9:22 P

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Igor Zamyatin
Like this? On Fri, May 31, 2013 at 3:45 PM, Uros Bizjak wrote: > On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin wrote: >> We do want to use the same register for float_extend. > > OK then. Please add a comment for this fact and also, please put > single-line preparation statements inside double-

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Uros Bizjak
On Fri, May 31, 2013 at 2:56 PM, Igor Zamyatin wrote: > Like this? Yes, but put the comment above the peephole2 pattern. The patch is OK for mainline with the above change. Thanks, Uros. > > On Fri, May 31, 2013 at 3:45 PM, Uros Bizjak wrote: >> On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Jakub Jelinek
On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote: > Like this? Sorry for nitpicking, but there are various formatting issues. + if (ix86_tune == PROCESSOR_SLM) +{ + if (has_scale) +return true; + if (split_cost < 1) +return false; + if (regno0 == r

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Robert Dewar
On 6/1/2013 9:52 AM, Jakub Jelinek wrote: Sorry for nitpicking, but there are various formatting issues. A number of these formatting issues could be easily detected by the compiler. It might be really useful to add a switch to do such detection. For Ada, the GNAT compiler has -gnatyg which en

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Jakub Jelinek
On Sat, Jun 01, 2013 at 03:52:55PM +0200, Jakub Jelinek wrote: > On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote: > > Like this? > > Sorry for nitpicking, but there are various formatting issues. Also: if (clock1 == clock2) { /* Determine winner - load must win.

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-03 Thread Yuri Rumyantsev
Hi, Jakub! Thanks a lot for you remarks! Attached is the patch which fixes all of them. Ok to install if all testing passes? Changelog: gcc/ 2013-06-03 Yuri Rumyantsev * config/i386/i386.c (ix86_lea_outperforms): Fix formatting. (ix86_avoid_lea_for_addr): Likewise.

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-03 Thread Jakub Jelinek
On Mon, Jun 03, 2013 at 05:00:38PM +0400, Yuri Rumyantsev wrote: > Thanks a lot for you remarks! > > Attached is the patch which fixes all of them. > > Ok to install if all testing passes? > > Changelog: > > gcc/ > > 2013-06-03 Yuri Rumyantsev Two spaces before name, not just one. >

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-03 Thread Yuri Rumyantsev
Thanks, Jakub! Updated Changelog: gcc/ 2013-06-03 Yuri Rumyantsev * config/i386/i386.c (ix86_lea_outperforms): Fix formatting. (ix86_avoid_lea_for_addr): Likewise. (exact_dependency_1): Likewise. (ix86_adjust_cost): Likewise. (swap_top_of_ready_list):

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-03 Thread Uros Bizjak
On Mon, Jun 3, 2013 at 4:43 PM, Yuri Rumyantsev wrote: > Updated Changelog: > > gcc/ > > 2013-06-03 Yuri Rumyantsev > > * config/i386/i386.c (ix86_lea_outperforms): Fix formatting. > (ix86_avoid_lea_for_addr): Likewise. > (exact_dependency_1): Likewise. > (ix86_