Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

On Fri, 4 Dec 2015, Jan Hubicka wrote: > > > > I wonder if you can split out the re-naming at this stage. Further > > comments below. > > OK, I will commit the renaming and ipa-icf fix separately. > > > > > Bootstrapped/regtested x86_64-linux, OK? > > > > > > I will work on some testcases

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

On Fri, 4 Dec 2015, Jan Hubicka wrote: > Hi, > this is the patch for fold-const.c. Can you think of some testcase for the > MR_DEPENDENCE_CLIQUE comparsion? I am not that familiar with the code to > be able to construct it :( With ICF it would involve a variant using restrict args vs.

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

> > > > Well, not exactly of the case mentioned above, but still think that this is > > safe (ugly, too). An alternative is to keep around the bodies until after > > inlining. I have infrastructure for that in my tree, but it is hard to > > tune to > > do: first the alternative function body

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

> On Fri, 4 Dec 2015, Jan Hubicka wrote: > > > Hi, > > this is the patch for fold-const.c. Can you think of some testcase for the > > MR_DEPENDENCE_CLIQUE comparsion? I am not that familiar with the code to > > be able to construct it :( > > With ICF it would involve a variant using restrict

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

On Fri, 4 Dec 2015, Jan Hubicka wrote: > Hi, > this is the last patch of the series. It makes operand_equal_p to compare > alias sets even in !flag_strict_aliasing before inlining so inlining > !flag_strict_aliasing to flag_strict_aliasing is possible when callee is > merged comdat. I tried to

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

> > I wonder if you can split out the re-naming at this stage. Further > comments below. OK, I will commit the renaming and ipa-icf fix separately. > > > Bootstrapped/regtested x86_64-linux, OK? > > > > I will work on some testcases for the ICF and fold-const that would lead > > to wrong code

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

On Fri, Dec 4, 2015 at 10:04 AM, Jan Hubicka wrote: > Hi, > this is the patch implementing renaming and fixing logic in ipa-icf/lto-symtab > WRT compuattion of this flag. I don't seem to be able to construct testcase > for > this: the merged flag is currently used in inliner

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

Hi, this is the patch implementing renaming and fixing logic in ipa-icf/lto-symtab WRT compuattion of this flag. I don't seem to be able to construct testcase for this: the merged flag is currently used in inliner only to decide whether to ingore optimize_size/optimize levels which should not

Re: -fstrict-aliasing fixes 6/6: permit inlining of comdats

Hi, this is the patch for fold-const.c. Can you think of some testcase for the MR_DEPENDENCE_CLIQUE comparsion? I am not that familiar with the code to be able to construct it :( Bootstrapped/regtested x86_64-linux, OK? Honza * fold-const.c (operand_equal_p): Do not use

-fstrict-aliasing fixes 6/6: permit inlining of comdats

Hi, this is the last patch of the series. It makes operand_equal_p to compare alias sets even in !flag_strict_aliasing before inlining so inlining !flag_strict_aliasing to flag_strict_aliasing is possible when callee is merged comdat. I tried to explain it in greater detail in the comment in