Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-14 Thread Jeff Law
On Sat, 2019-12-14 at 15:33 +0100, John Paul Adrian Glaubitz wrote: > Hi Stefan! > > > The problems are in the gcc implementation > > > > - the lra implementation is buggy > > - the compare elimination can't handle parallel's containing a compare > > - df-core considers parallel's containing a

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-14 Thread John Paul Adrian Glaubitz
Hi Stefan! > The problems are in the gcc implementation > > - the lra implementation is buggy > - the compare elimination can't handle parallel's containing a compare > - df-core considers parallel's containing a compare also as a USE > - some optimizations/mechanisms do only work if HAVE_CC0 is

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Segher Boessenkool
On Sat, Dec 14, 2019 at 12:06:36AM +0900, Oleg Endo wrote: > On Fri, 2019-12-13 at 15:57 +0100, John Paul Adrian Glaubitz wrote: > > Hello Segher! Hi :-) > > > With LRA, sh builds fine (with the combine2 patches). I have no idea > > > if correct code is generated, but it doesn't ICE anymore. >

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Richard Sandiford
John Paul Adrian Glaubitz writes: > Hi! > > On 12/13/19 4:06 PM, Oleg Endo wrote: >>> What are the combine2 patches? >> >> See the other thread that I've linked in my message. > > I don't see any patch there. The latest version is: https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00287.html

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Oleg Endo
On Fri, 2019-12-13 at 16:09 +0100, John Paul Adrian Glaubitz wrote: > Hi! > > On 12/13/19 4:06 PM, Oleg Endo wrote: > > > What are the combine2 patches? > > > > See the other thread that I've linked in my message. > > I don't see any patch there. You'd have to crawl up the discussion or so.

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread John Paul Adrian Glaubitz
Hi! On 12/13/19 4:06 PM, Oleg Endo wrote: >> What are the combine2 patches? > > See the other thread that I've linked in my message. I don't see any patch there. >> And I would support switching SH to LRA as >> there are a few cases (Debian packages) where GCC fails with an internal >>

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Jeff Law
On Fri, 2019-12-13 at 05:03 -0600, Segher Boessenkool wrote: > On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: > > I doubt it will be long before we deprecate > > all targets that require old reload.) > > Do we wait until GCC 12 (to remove old reload completely)? If not, we >

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Oleg Endo
On Fri, 2019-12-13 at 15:57 +0100, John Paul Adrian Glaubitz wrote: > Hello Segher! > > > With LRA, sh builds fine (with the combine2 patches). I have no idea > > if correct code is generated, but it doesn't ICE anymore. > > What are the combine2 patches? See the other thread that I've linked

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread John Paul Adrian Glaubitz
Hello Segher! > With LRA, sh builds fine (with the combine2 patches). I have no idea > if correct code is generated, but it doesn't ICE anymore. What are the combine2 patches? And I would support switching SH to LRA as there are a few cases (Debian packages) where GCC fails with an internal

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Oleg Endo
On Fri, 2019-12-13 at 08:09 -0600, Segher Boessenkool wrote: > On Fri, Dec 13, 2019 at 10:06:20PM +0900, Oleg Endo wrote: > > On Fri, 2019-12-13 at 05:03 -0600, Segher Boessenkool wrote: > > > On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford > > > wrote: > > > > I doubt it will be long

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Segher Boessenkool
On Fri, Dec 13, 2019 at 01:19:55PM +0100, Richard Biener wrote: > On December 13, 2019 12:03:30 PM GMT+01:00, Segher Boessenkool > wrote: > >On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: > >> I doubt it will be long before we deprecate > >> all targets that require old

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Segher Boessenkool
On Fri, Dec 13, 2019 at 10:06:20PM +0900, Oleg Endo wrote: > On Fri, 2019-12-13 at 05:03 -0600, Segher Boessenkool wrote: > > On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: > > > I doubt it will be long before we deprecate > > > all targets that require old reload.) > > > > Do

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Oleg Endo
On Fri, 2019-12-13 at 05:03 -0600, Segher Boessenkool wrote: > On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: > > I doubt it will be long before we deprecate > > all targets that require old reload.) > > Do we wait until GCC 12 (to remove old reload completely)? If not, we >

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Richard Biener
On December 13, 2019 12:03:30 PM GMT+01:00, Segher Boessenkool wrote: >On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: >> I doubt it will be long before we deprecate >> all targets that require old reload.) > >Do we wait until GCC 12 (to remove old reload completely)? If not,

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Segher Boessenkool
On Thu, Dec 12, 2019 at 09:32:27AM +, Richard Sandiford wrote: > I doubt it will be long before we deprecate > all targets that require old reload.) Do we wait until GCC 12 (to remove old reload completely)? If not, we should deprecate it now. Segher

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-13 Thread Segher Boessenkool
On Thu, Dec 12, 2019 at 07:43:58AM +0100, Stefan Franke wrote: > The problems are in the gcc implementation > > - the lra implementation is buggy Patches welcome. Bug reports welcome. "It does not work" does not really help anyone -- you don't even say *what* doesn't work. > - the compare

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-12 Thread Stefan Franke
Am 2019-12-12 10:32, schrieb Richard Sandiford: Stefan Franke writes: Am 2019-12-08 01:54, schrieb Oleg Endo: On Tue, 2019-11-26 at 07:38 +0100, ste...@franke.ms wrote: > On 11/21/19 10:30 AM, ste...@franke.ms wrote: > > Hi there, > > > > here is mc68k's patch to switch the m68k architecture

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-12 Thread Richard Sandiford
Stefan Franke writes: > Am 2019-12-08 01:54, schrieb Oleg Endo: >> On Tue, 2019-11-26 at 07:38 +0100, ste...@franke.ms wrote: >>> > On 11/21/19 10:30 AM, ste...@franke.ms wrote: >>> > > Hi there, >>> > > >>> > > here is mc68k's patch to switch the m68k architecture over to ccmode >>> > > and >>>

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-12 Thread Richard Biener
On December 12, 2019 7:43:58 AM GMT+01:00, Stefan Franke wrote: >Am 2019-12-08 01:54, schrieb Oleg Endo: >> On Tue, 2019-11-26 at 07:38 +0100, ste...@franke.ms wrote: >>> > On 11/21/19 10:30 AM, ste...@franke.ms wrote: >>> > > Hi there, >>> > > >>> > > here is mc68k's patch to switch the m68k

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-11 Thread Stefan Franke
Am 2019-12-08 01:54, schrieb Oleg Endo: On Tue, 2019-11-26 at 07:38 +0100, ste...@franke.ms wrote: > On 11/21/19 10:30 AM, ste...@franke.ms wrote: > > Hi there, > > > > here is mc68k's patch to switch the m68k architecture over to ccmode > > and > > lra. See https://github.com/mc68kghost/gcc

Re: AW: [PATCH] m68k architecture: support ccmode + lra

2019-12-07 Thread Oleg Endo
On Tue, 2019-11-26 at 07:38 +0100, ste...@franke.ms wrote: > > On 11/21/19 10:30 AM, ste...@franke.ms wrote: > > > Hi there, > > > > > > here is mc68k's patch to switch the m68k architecture over to ccmode and > > > lra. See https://github.com/mc68kghost/gcc 68k-ccmode branch. > > > > Bernd

AW: [PATCH] m68k architecture: support ccmode + lra

2019-11-25 Thread stefan
> On 11/21/19 10:30 AM, ste...@franke.ms wrote: > > Hi there, > > > > here is mc68k's patch to switch the m68k architecture over to ccmode and > > lra. See https://github.com/mc68kghost/gcc 68k-ccmode branch. > Bernd Schmidt posted a conversion of the m68k port to ccmode a couple > weeks before