Re: Add checkpoint to libgomp dg-shouldfail tests

2015-09-30 Thread Thomas Schwinge
Hi! On Sun, 27 Sep 2015 18:55:53 +0200, Jakub Jelinek wrote: > > > OK for trunk? > > Ok. Thanks for the review. Committed in r228282: commit e344dc2e94177f522fe8d62fe95ec2d1687e017a Author: tschwinge Date: Wed Sep 30 08:44:49 2015 + Add checkpoint to libgomp dg-s

Re: Add checkpoint to libgomp dg-shouldfail tests

2015-09-27 Thread Jakub Jelinek
Hi! > > OK for trunk? Ok. Jakub

Re: Add checkpoint to libgomp dg-shouldfail tests

2015-09-27 Thread FX
> Hi! > Ping. OK for the Fortran part, though I suspect you need Jakub to approve it as well. FX

Re: Add checkpoint to libgomp dg-shouldfail tests

2015-09-27 Thread Thomas Schwinge
\]+\\\) object when > > > \\\[0x\[0-9a-f\]+..0x\[0-9a-f\]+\\\) is already mapped" } > > > +/* { dg-shouldfail "" } */ > > > > It once occurred to me that it's also a good idea to verify that we're > > actually reaching the expected ch

Re: Add checkpoint to libgomp dg-shouldfail tests

2015-08-14 Thread Thomas Schwinge
we're > actually reaching the expected checkpoint before terminating -- OK to > commit? OK for trunk? commit 97f963dc86199ef2237fffa6293d4dfdacbd1e59 Author: Thomas Schwinge Date: Fri Aug 14 17:51:03 2015 +0200 Add checkpoint to libgomp dg-shouldfail tests That is, verify t

Re: Add checkpoint to libgomp dg-shouldfail tests (was: [PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests)

2015-08-14 Thread FX
> (Can a Fortran person please comment on this: as it's nontrivial to write > to stderr, let's just write to stdout followed by a flush, which does > have the same ordering effect -- OK?) Although there are no absolute guarantees on flushing, it should work in practice. Note that the FLUSH subro

Re: Add checkpoint to libgomp dg-shouldfail tests (was: [PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests)

2015-08-14 Thread Janne Blomqvist
On Fri, Aug 14, 2015 at 1:56 PM, Thomas Schwinge wrote: > Hi! > > (Can a Fortran person please comment on this: as it's nontrivial to write > to stderr, let's just write to stdout followed by a flush, which does > have the same ordering effect -- OK?) If you want to write to stderr, with gfortran

Add checkpoint to libgomp dg-shouldfail tests (was: [PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests)

2015-08-14 Thread Thomas Schwinge
ct when > \\\[0x\[0-9a-f\]+..0x\[0-9a-f\]+\\\) is already mapped" } > +/* { dg-shouldfail "" } */ It once occurred to me that it's also a good idea to verify that we're actually reaching the expected checkpoint before terminating -- OK to commit? commit 105522789919a4