Re: Convert more non-GTY htab_t to hash_table.

2012-10-09 Thread Lawrence Crowl
On 10/5/12, Diego Novillo wrote: > On Oct 3, 2012 Lawrence Crowl wrote: > > Change more non-GTY hash tables to use the new type-safe > > template hash table. Constify member function parameters that > > can be const. Correct a couple of expressions in formerly > > uninstantiated templates. > >

Re: Convert more non-GTY htab_t to hash_table.

2012-10-08 Thread Mike Stump
On Oct 5, 2012, at 3:19 PM, Diego Novillo wrote: > On Fri, Oct 5, 2012 at 6:08 PM, Lawrence Crowl wrote: > >>> For many people the time to compile (almost) empty file is very >>> important, we are already bad about that right now, initializing >>> too much stuff dynamically is going to make it w

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Diego Novillo
On Wed, Oct 3, 2012 at 6:46 PM, Lawrence Crowl wrote: > On 10/2/12, Richard Guenther wrote: >> You are changing a hashtable used by fold checking, did you test >> with fold checking enabled? > > One small thinko fixed. Patch passes tests. > >> The cfg.c, dse.c and hash-table.h parts are ok for

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Diego Novillo
On Fri, Oct 5, 2012 at 6:08 PM, Lawrence Crowl wrote: >> For many people the time to compile (almost) empty file is very >> important, we are already bad about that right now, initializing >> too much stuff dynamically is going to make it worse. > > So far, we are looking at dynamic initializatio

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
On 10/5/12, Jakub Jelinek wrote: > On Fri, Oct 05, 2012 at 01:59:18PM -0700, Lawrence Crowl wrote: > > With the constructor, you don't have to remember and you don't > > have to type more. If you have a variable, you know that it is > > properly initialized. > > But we really don't want hundreds

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 01:59:18PM -0700, Lawrence Crowl wrote: > With the constructor, you don't have to remember and you don't > have to type more. If you have a variable, you know that it is > properly initialized. But we really don't want hundreds or thousands of dynamic constructors for glob

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
Could you please review the patch at http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg40961.html? On 10/3/12, Lawrence Crowl wrote: > Sorry, one more time with the right file contents. > > On 10/2/12, Richard Guenther wrote: >> You are changing a hashtable used by fold checking, did you te

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
On 10/5/12, Richard Guenther wrote: > On Thu, 4 Oct 2012, Lawrence Crowl wrote: >> On 10/4/12, Richard Guenther wrote: >> > On Tue, 2 Oct 2012, Lawrence Crowl wrote: >> >> On 10/2/12, Richard Guenther wrote: >> >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: >> >> > > Change more non-GTY hash tab

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Richard Guenther
On Thu, 4 Oct 2012, Lawrence Crowl wrote: > On 10/4/12, Richard Guenther wrote: > > On Tue, 2 Oct 2012, Lawrence Crowl wrote: > >> On 10/2/12, Richard Guenther wrote: > >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > >> > > Change more non-GTY hash tables to use the new type-safe > >> > > templ

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Lawrence Crowl
On 10/4/12, Richard Guenther wrote: > On Tue, 2 Oct 2012, Lawrence Crowl wrote: >> On 10/2/12, Richard Guenther wrote: >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: >> > > Change more non-GTY hash tables to use the new type-safe >> > > template hash table. Constify member function parameters th

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Richard Guenther
On Tue, 2 Oct 2012, Lawrence Crowl wrote: > On 10/2/12, Richard Guenther wrote: > > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > > > Change more non-GTY hash tables to use the new type-safe > > > template hash table. Constify member function parameters that > > > can be const. Correct a couple o

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
Sorry, one more time with the right file contents. On 10/2/12, Richard Guenther wrote: > You are changing a hashtable used by fold checking, did you test > with fold checking enabled? One small thinko fixed. Patch passes tests. > The cfg.c, dse.c and hash-table.h parts are ok for trunk, I'll >

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
On 10/2/12, Richard Guenther wrote: > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > >> Change more non-GTY hash tables to use the new type-safe template hash >> table. >> Constify member function parameters that can be const. >> Correct a couple of expressions in formerly uninstantiated templates. >

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Jakub Jelinek
On Wed, Oct 03, 2012 at 09:54:45AM -0700, Lawrence Crowl wrote: > On 10/2/12, Ian Lance Taylor wrote: > > On Oct 2, 2012 Lawrence Crowl wrote: > > > On 10/2/12, Richard Guenther wrote: > > > > You are changing a hashtable used by fold checking, did you > > > > test with fold checking enabled? >

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
On 10/2/12, Ian Lance Taylor wrote: > On Oct 2, 2012 Lawrence Crowl wrote: > > On 10/2/12, Richard Guenther wrote: > > > You are changing a hashtable used by fold checking, did you > > > test with fold checking enabled? > > > > I didn't know I had to do anything beyond the normal make check. > >

Re: Convert more non-GTY htab_t to hash_table.

2012-10-02 Thread Ian Lance Taylor
On Tue, Oct 2, 2012 at 12:10 PM, Lawrence Crowl wrote: > On 10/2/12, Richard Guenther wrote: >> >> You are changing a hashtable used by fold checking, did you test >> with fold checking enabled? > > I didn't know I had to do anything beyond the normal make check. > What do I do? Fold checking is

Re: Convert more non-GTY htab_t to hash_table.

2012-10-02 Thread Lawrence Crowl
On 10/2/12, Richard Guenther wrote: > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > > Change more non-GTY hash tables to use the new type-safe > > template hash table. Constify member function parameters that > > can be const. Correct a couple of expressions in formerly > > uninstantiated template

Re: Convert more non-GTY htab_t to hash_table.

2012-10-02 Thread Richard Guenther
On Mon, 1 Oct 2012, Lawrence Crowl wrote: > Change more non-GTY hash tables to use the new type-safe template hash table. > Constify member function parameters that can be const. > Correct a couple of expressions in formerly uninstantiated templates. > > The new code is 0.362% faster in bootstrap

Convert more non-GTY htab_t to hash_table.

2012-10-01 Thread Lawrence Crowl
Change more non-GTY hash tables to use the new type-safe template hash table. Constify member function parameters that can be const. Correct a couple of expressions in formerly uninstantiated templates. The new code is 0.362% faster in bootstrap, with a 99.5% confidence of being faster. Tested on