[BUILDROBOT] RISC-V: ‘profile_probability’ has not been declared (was: Convert profile probabilities to new type)

Hi Jan, hi Kito, Palmer and Andrew! On Thu, 2017-06-29 14:27:41 +0200, Jan Hubicka wrote: > this is second step of the profile maintenance revamp. It implements > profile_probability type which is pretty much symmetric to profile_count > except that it implements fixed point

Re: Convert profile probabilities to new type

> The following patch should restore things: > > diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c > index dd72828..fa88259 100644 > --- a/gcc/sel-sched-ir.c > +++ b/gcc/sel-sched-ir.c > @@ -4747,8 +4747,10 @@ compute_succs_info (insn_t insn, short flags) >sinfo->probs_ok.safe_push

Re: Convert profile probabilities to new type

Hi, I have checked in the following fix. Index: config/pa/pa.c === --- config/pa/pa.c (revision 249854) +++ config/pa/pa.c (working copy) @@ -10723,7 +10723,8 @@ pa_expand_compare_and_swap_loop (rtx mem /* Mark this

Re: Convert profile probabilities to new type

Also seeing a possibly related failure from my glibc bot, building for hppa-linux-gnu: /scratch/jmyers/glibc-bot/src/gcc/gcc/config/pa/pa.c: In function 'bool pa_expand_compare_and_swap_loop(rtx, rtx, rtx, rtx)': /scratch/jmyers/glibc-bot/src/gcc/gcc/config/pa/pa.c:10726:59: error: could not

Re: Convert profile probabilities to new type

> > After the change, edges that fail the predicate contribute REG_BR_PROB_BASE in > the upper hunk, but 0 in the lower hunk. Before the change, they contributed 0 > in both cases. > > The following patch should restore things: > > diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c > index

Re: Convert profile probabilities to new type

On Fri, 30 Jun 2017, Andreas Schwab wrote: > This breaks ia64, a lot of testsuite failures like this: > > FAIL: c-c++-common/torture/pr53505.c -O3 -fomit-frame-pointer > -funroll-loops -fpeel-loops -ftracer -finline-functions (internal compiler > error) > FAIL:

Re: Convert profile probabilities to new type

This breaks ia64, a lot of testsuite failures like this: FAIL: c-c++-common/torture/pr53505.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (internal compiler error) FAIL: c-c++-common/torture/pr53505.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops

Re: Convert profile probabilities to new type

Hi, this patch makes cross compiler for all three targets to build again. Comitted as obvious. * arm/arm-builtins.c: Include profile-count.h * except.c (sjlj_emit_function_enter): Use profile_probability::unlikely. Index: config/arm/arm-builtins.c

Re: Convert profile probabilities to new type

On Thu, Jun 29, 2017 at 11:24 PM, Jan Hubicka wrote: >> On Thu, Jun 29, 2017 at 11:19 PM, Jan Hubicka wrote: >> >> After this commit (r249800), GCC builds fail for arm and aarch64: >> >> >> >> /gccsrc/gcc/except.c: In function ???void >> >>

Re: Convert profile probabilities to new type

> On Thu, Jun 29, 2017 at 11:19 PM, Jan Hubicka wrote: > >> After this commit (r249800), GCC builds fail for arm and aarch64: > >> > >> /gccsrc/gcc/except.c: In function ???void > >> sjlj_emit_function_enter(rtx_code_label*)???: > >> /gcc-fsf/gccsrc/gcc/except.c:1183: error:

Re: Convert profile probabilities to new type

On Thu, Jun 29, 2017 at 11:19 PM, Jan Hubicka wrote: >> After this commit (r249800), GCC builds fail for arm and aarch64: >> >> /gccsrc/gcc/except.c: In function ???void >> sjlj_emit_function_enter(rtx_code_label*)???: >> /gcc-fsf/gccsrc/gcc/except.c:1183: error: conversion from

Re: Convert profile probabilities to new type

> After this commit (r249800), GCC builds fail for arm and aarch64: > > /gccsrc/gcc/except.c: In function ???void > sjlj_emit_function_enter(rtx_code_label*)???: > /gcc-fsf/gccsrc/gcc/except.c:1183: error: conversion from ???int??? to > non-scalar type ???profile_probability??? requested >