Re: Do not compute alias sets for types that don't need them

2015-05-27 Thread Richard Biener
On Tue, 26 May 2015, Jan Hubicka wrote: Hi, On Fri, 22 May 2015, Jan Hubicka wrote: Index: tree-streamer-out.c === --- tree-streamer-out.c (revision 223508) +++ tree-streamer-out.c (working copy) @@

Re: Do not compute alias sets for types that don't need them

2015-05-27 Thread Richard Biener
On Wed, 27 May 2015, Jan Hubicka wrote: I am not sure if TYPE_MAIN_VARIANT is really needed here. What I know is that complete types may have incomplete variants. How can that be? TYPE_FIELDS is shared across variants and all variants should be layed out. Because

Re: Do not compute alias sets for types that don't need them

2015-05-27 Thread Jan Hubicka
On Tue, 26 May 2015, Jan Hubicka wrote: Hi, On Fri, 22 May 2015, Jan Hubicka wrote: Index: tree-streamer-out.c === --- tree-streamer-out.c (revision 223508) +++ tree-streamer-out.c (working copy)

Re: Do not compute alias sets for types that don't need them

2015-05-26 Thread Jan Hubicka
I am not sure if TYPE_MAIN_VARIANT is really needed here. What I know is that complete types may have incomplete variants. How can that be? TYPE_FIELDS is shared across variants and all variants should be layed out. Because TYPE_FILEDS are not always shared across variants. For

Re: Do not compute alias sets for types that don't need them

2015-05-26 Thread Jan Hubicka
I am not sure if TYPE_MAIN_VARIANT is really needed here. What I know is that complete types may have incomplete variants. How can that be? TYPE_FIELDS is shared across variants and all variants should be layed out. Because TYPE_FILEDS are not always shared across

Re: Do not compute alias sets for types that don't need them

2015-05-26 Thread Richard Biener
On Fri, 22 May 2015, Jan Hubicka wrote: Index: emit-rtl.c === --- emit-rtl.c(revision 223508) +++ emit-rtl.c(working copy) @@ -1787,8 +1787,15 @@ set_mem_attributes_minus_bitpos (rtx ref memset (attrs, 0,

Re: Do not compute alias sets for types that don't need them

2015-05-26 Thread Michael Matz
Hi, On Fri, 22 May 2015, Jan Hubicka wrote: Index: tree-streamer-out.c === --- tree-streamer-out.c (revision 223508) +++ tree-streamer-out.c (working copy) @@ -346,6 +346,7 @@ pack_ts_type_common_value_fields

Re: Do not compute alias sets for types that don't need them

2015-05-26 Thread Jan Hubicka
Hi, On Fri, 22 May 2015, Jan Hubicka wrote: Index: tree-streamer-out.c === --- tree-streamer-out.c (revision 223508) +++ tree-streamer-out.c (working copy) @@ -346,6 +346,7 @@ pack_ts_type_common_value_fields

Re: Do not compute alias sets for types that don't need them

2015-05-22 Thread Richard Biener
On Fri, 22 May 2015, Jan Hubicka wrote: Hi, this patch fixes few cases where we compute alias type and don't need to that are found by adding type_with_alias_set_p check to alias.c (I will send this patch separately as there is still one ICE caught by it I believe originating from

Do not compute alias sets for types that don't need them

2015-05-22 Thread Jan Hubicka
Hi, this patch fixes few cases where we compute alias type and don't need to that are found by adding type_with_alias_set_p check to alias.c (I will send this patch separately as there is still one ICE caught by it I believe originating from ipa-icf-gimple, I have more involved fix for that) The

Re: Do not compute alias sets for types that don't need them

2015-05-22 Thread Jan Hubicka
Index: emit-rtl.c === --- emit-rtl.c (revision 223508) +++ emit-rtl.c (working copy) @@ -1787,8 +1787,15 @@ set_mem_attributes_minus_bitpos (rtx ref memset (attrs, 0, sizeof (attrs)); /* Get the alias