Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-17 Thread Jan Hubicka
> On Fri, Apr 15, 2011 at 15:20, Xinliang David Li wrote: > > This is a trivial patch to deal with bad profile data (from > > multi-threaded programs) that leads to divide by zero error. > > > > Ok for trunk? > > > > Thanks, > > > > David > > > > > > > > 2011-04-15  Xinliang David Li   > > > >    

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 16:21, Xinliang David Li wrote: > There is no way to get a test case that can produce the problem in a > deterministic way.  There is really not much for Honza to review > though :) The check may be needed somewhere else, you may be papering over the real issue. I don't t

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Xinliang David Li
There is no way to get a test case that can produce the problem in a deterministic way. There is really not much for Honza to review though :) David On Fri, Apr 15, 2011 at 12:52 PM, Diego Novillo wrote: > On Fri, Apr 15, 2011 at 15:20, Xinliang David Li wrote: >> This is a trivial patch to de

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 15:20, Xinliang David Li wrote: > This is a trivial patch to deal with bad profile data (from > multi-threaded programs) that leads to divide by zero error. > > Ok for trunk? > > Thanks, > > David > > > > 2011-04-15  Xinliang David Li   > >        * ipa-inline.c (cgraph_dec

FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Xinliang David Li
This is a trivial patch to deal with bad profile data (from multi-threaded programs) that leads to divide by zero error. Ok for trunk? Thanks, David 2011-04-15 Xinliang David Li * ipa-inline.c (cgraph_decide_recursive_inlining): Fix div by zero error with insane profile. I