Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-22 Thread Joseph S. Myers
On Thu, 21 Apr 2011, Xinliang David Li wrote: > Please review the new patch. The new patch is OK with a suitable ChangeLog entry. -- Joseph S. Myers jos...@codesourcery.com

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Xinliang David Li
Please review the new patch. Thanks, David On Thu, Apr 21, 2011 at 3:59 PM, Joseph S. Myers wrote: > On Thu, 21 Apr 2011, Xinliang David Li wrote: > >> On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers >> wrote: >> > On Tue, 19 Apr 2011, Xinliang David Li wrote: >> > >> >> 2011-04-18  Neil Vac

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Xinliang David Li
That will work. Revised patch coming up. Thanks, David On Thu, Apr 21, 2011 at 3:59 PM, Joseph S. Myers wrote: > On Thu, 21 Apr 2011, Xinliang David Li wrote: > >> On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers >> wrote: >> > On Tue, 19 Apr 2011, Xinliang David Li wrote: >> > >> >> 2011-04-

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Joseph S. Myers
On Thu, 21 Apr 2011, Xinliang David Li wrote: > On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers > wrote: > > On Tue, 19 Apr 2011, Xinliang David Li wrote: > > > >> 2011-04-18  Neil Vachharajani   > >> > >>     * flags.c:  New flag variable. > >>     * opts.c (common_handle_options): Set flag_we

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Xinliang David Li
On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers wrote: > On Tue, 19 Apr 2011, Xinliang David Li wrote: > >> 2011-04-18  Neil Vachharajani   >> >>     * flags.c:  New flag variable. >>     * opts.c (common_handle_options): Set flag_werror_set. >>     * opts-global.c (decode_options): Delay Werror

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Joseph S. Myers
On Tue, 19 Apr 2011, Xinliang David Li wrote: > 2011-04-18 Neil Vachharajani > > * flags.c: New flag variable. > * opts.c (common_handle_options): Set flag_werror_set. > * opts-global.c (decode_options): Delay Werror decision > for Wcoverage-mismatch util after options are par

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-21 Thread Xinliang David Li
Ping .. David On Wed, Apr 20, 2011 at 9:34 AM, Xinliang David Li wrote: > This would work if there is a way to set Werror=coverage-mismatch > without having to explicitly set the option classification as > DK_ERROR.   Does this mechanism exist? > > Thanks, > > David > > On Tue, Apr 19, 2011 at 1

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-20 Thread Xinliang David Li
This would work if there is a way to set Werror=coverage-mismatch without having to explicitly set the option classification as DK_ERROR. Does this mechanism exist? Thanks, David On Tue, Apr 19, 2011 at 12:52 AM, Richard Guenther wrote: > On Tue, Apr 19, 2011 at 9:13 AM, Xinliang David Li wr

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 9:13 AM, Xinliang David Li wrote: > -Wcoverage-mismatch is enabled by default, and the warning is promoted > to error by default. However in the current implementation -Wno-error > can not demote the error back to warning. The patch was ported from > one contributed by Neil

FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Xinliang David Li
-Wcoverage-mismatch is enabled by default, and the warning is promoted to error by default. However in the current implementation -Wno-error can not demote the error back to warning. The patch was ported from one contributed by Neil. OK for trunk after regression testing? 2011-04-18 Neil Vachha