Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-19 Thread Jan Hubicka
On Aug 17, 2013, at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Moreover objc apparently never produce any virtual functions/methods. Objective-C++ might. :-) Sure, those ought to be regular C++ methods though. Can someone explain me in greater detail how the objc use works?

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-19 Thread Richard Biener
Jan Hubicka hubi...@ucw.cz wrote: On Aug 17, 2013, at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Moreover objc apparently never produce any virtual functions/methods. Objective-C++ might. :-) Sure, those ought to be regular C++ methods though. Can someone explain me in greater detail

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-18 Thread Mike Stump
On Aug 17, 2013, at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Moreover objc apparently never produce any virtual functions/methods. Objective-C++ might. :-) Can someone explain me in greater detail how the objc use works? Objective-C uses it to manage code generation for post-increments of

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-17 Thread Jan Hubicka
This patch causes an ICE when building libobjc, which is part of normal bootstrap. PR 58179 /nasfarm/edelsohn/src/src/libobjc/accessors.m: In function 'objc_getProperty': /nasfarm/edelsohn/src/src/libobjc/accessors.m:127:11: internal compiler error: in obj_type_ref_class, at tree.c:11876

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-17 Thread Jan Hubicka
Hi, this is the patch I comitted after testing. My apologizes for the breakage. Honza Index: ChangeLog === --- ChangeLog (revision 201816) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2013-08-16 Jan Hubicka j...@suse.cz + +

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-17 Thread Gerald Pfeifer
On Sat, 17 Aug 2013, Jan Hubicka wrote: this is the patch I comitted after testing. My apologizes for the breakage. +2013-08-16 Jan Hubicka j...@suse.cz + + PR middle-end/58179 + * tree.c (obj_type_ref_class): Do not ICE on non-method calls. This fixes my bootstraps on

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-16 Thread Jan Hubicka
Thanks, this is version I commited after testing at ppc64-linux. The difference is that it also updates code suffering from the same problem in gimple_extract_devirt_binfo_from_cst. I originally intended to rewrite the function but after yesterday discussion with Martin I think it will take me

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-16 Thread David Edelsohn
This patch causes an ICE when building libobjc, which is part of normal bootstrap. PR 58179 /nasfarm/edelsohn/src/src/libobjc/accessors.m: In function 'objc_getProperty': /nasfarm/edelsohn/src/src/libobjc/accessors.m:127:11: internal compiler error: in obj_type_ref_class, at tree.c:11876

Fix class type lookup from OBJ_TYPE_REF

2013-08-15 Thread Jan Hubicka
Hi, while working on the devirt code, I noticed that sometimes we get as a type of object a non-classes (like void types). This is because we look up object's class from the OBJ_TYPE_REF_OBJECT and this is a generic pointer that gimple passes like to change type of. I tracked down few cases. For

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-15 Thread Richard Biener
Jan Hubicka hubi...@ucw.cz wrote: Hi, while working on the devirt code, I noticed that sometimes we get as a type of object a non-classes (like void types). This is because we look up object's class from the OBJ_TYPE_REF_OBJECT and this is a generic pointer that gimple passes like to change type