Fix compiler warnings

2015-05-06 Thread Aditya K
I recently compiled gcc with clang and found few useful warnings (https://gcc.gnu.org/ml/gcc/2015-05/msg00015.html, https://gcc.gnu.org/ml/gcc/2015-05/msg00041.html). I have a patch to fix some of those, it passes bootstrap, please apply these if it is useful. Thanks, -Aditya

Re: Fix compiler warnings

2015-05-06 Thread Trevor Saunders
On Wed, May 06, 2015 at 01:47:38PM +, Aditya K wrote: > I recently compiled gcc with clang and found few useful warnings > (https://gcc.gnu.org/ml/gcc/2015-05/msg00015.html, > https://gcc.gnu.org/ml/gcc/2015-05/msg00041.html). > I have a patch to fix some of those, it passes bootstrap, please

Re: Fix compiler warnings

2015-05-06 Thread Jakub Jelinek
Hi! See Trevor's comments on ChangeLog. diff --git a/gcc/reload.h b/gcc/reload.h index c777e54..ae86150 100644 --- a/gcc/reload.h +++ b/gcc/reload.h @@ -168,7 +168,7 @@ struct target_reload { value indicates the level of indirect addressing supported, e.g., two means that (MEM (MEM (R

Re: Fix compiler warnings

2015-05-06 Thread Richard Sandiford
Jakub Jelinek writes: > Hi! > > See Trevor's comments on ChangeLog. > > diff --git a/gcc/reload.h b/gcc/reload.h > index c777e54..ae86150 100644 > --- a/gcc/reload.h > +++ b/gcc/reload.h > @@ -168,7 +168,7 @@ struct target_reload { > value indicates the level of indirect addressing supported

Re: Fix compiler warnings

2015-05-06 Thread Marek Polacek
On Wed, May 06, 2015 at 04:58:03PM +0200, Jakub Jelinek wrote: > Also, it would be nice to figure why gcc doesn't warn (for both meaningful > changes, in the first snippet I believe gcc just determines the static > function is noreturn and that is why it correctly doesn't warn). > I thought Marek h

Re: Fix compiler warnings

2015-05-06 Thread Jakub Jelinek
On Wed, May 06, 2015 at 06:18:23PM +0200, Marek Polacek wrote: > On Wed, May 06, 2015 at 04:58:03PM +0200, Jakub Jelinek wrote: > > Also, it would be nice to figure why gcc doesn't warn (for both meaningful > > changes, in the first snippet I believe gcc just determines the static > > function is n

Re: Fix compiler warnings

2015-05-06 Thread Jakub Jelinek
On Wed, May 06, 2015 at 04:22:13PM +, Aditya K wrote: > Thanks Richard, Jakub and Trevor for the feedback. I have reformatted the > changelog, and modified the patch addressing your comments. > > -Aditya > > > 2015-05-06 Aditya Kumar > > * gcov-tool.c (do_merge): > * ipa

RE: Fix compiler warnings

2015-05-06 Thread Aditya K
d, 6 May 2015 18:26:10 +0200 > From: ja...@redhat.com > To: hiradi...@msn.com > CC: rdsandif...@googlemail.com; pola...@redhat.com; gcc-patches@gcc.gnu.org > Subject: Re: Fix compiler warnings > > On Wed, May 06, 2015 at 04:22:13PM +, Aditya K wrote: >> Thanks Richard

Re: Fix compiler warnings

2015-05-06 Thread Jakub Jelinek
On Wed, May 06, 2015 at 06:18:23PM +0200, Marek Polacek wrote: > On Wed, May 06, 2015 at 04:58:03PM +0200, Jakub Jelinek wrote: > > Also, it would be nice to figure why gcc doesn't warn (for both meaningful > > changes, in the first snippet I believe gcc just determines the static > > function is n

Re: Fix compiler warnings

2015-05-07 Thread Jakub Jelinek
On Wed, May 06, 2015 at 04:37:49PM +, Aditya K wrote: > Thanks! Updated patch. > > > 2015-05-06  Aditya Kumar  > >     * gcov-tool.c (do_merge): Refactored to remove int ret. >     * ipa-icf.c (sem_item::hash_referenced_symbol_properties): Changed > (!type == FUNC) to (type != FUNC

RE: Fix compiler warnings

2015-05-07 Thread Aditya K
Thank you very much Jakub. -Aditya > Date: Thu, 7 May 2015 19:58:11 +0200 > From: ja...@redhat.com > To: hiradi...@msn.com > CC: gcc-patches@gcc.gnu.org > Subject: Re: Fix compiler warnings > > On Wed, May 06, 2015 at 04:37:49PM

[patch,committed][OG9] Fix compiler warnings

2019-09-18 Thread Tobias Burnus
Committed the following patch to silence compiler warnings – some pointed to issues, which are now fixed. Tobias commit 500483e6ced44e2e0fea6a37e4f8c267ebaf826a Author: Tobias Burnus Date: Wed Sep 18 08:44:20 2019 +0200 Silence compiler warnings gcc/ 2019-09-17 Tobias Burn

Fix compiler warnings in ThreadSanitizer tests (issue5483046)

2011-12-12 Thread Dmitriy Vyukov
This is for google-main branch. Fix compiler warnings in ThreadSanitizer tests. Index: gcc/testsuite/ChangeLog.google-main === --- gcc/testsuite/ChangeLog.google-main (revision 182235) +++ gcc/testsuite/ChangeLog.google-main (working

Re: Fix compiler warnings in ThreadSanitizer tests (issue 5483046)

2011-12-12 Thread davidxl
ok for google/main. David http://codereview.appspot.com/5483046/