Re: Fix move_if_noexcept usages in _Hashtable

2018-12-16 Thread François Dumont
I reviewed this patch following result of making std::pair piecewise constructor noexcept: https://gcc.gnu.org/ml/libstdc++/2018-12/msg00052.html I restore check of noexcept qualification on move constructor rather than alloc::construct cause when dealing with std::pairValue> I want to check f

Re: Fix move_if_noexcept usages in _Hashtable

2018-12-04 Thread François Dumont
On 12/4/18 3:38 PM, Jonathan Wakely wrote: On 04/12/18 07:45 +0100, François Dumont wrote: Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which mi

Re: Fix move_if_noexcept usages in _Hashtable

2018-12-04 Thread Jonathan Wakely
On 04/12/18 07:45 +0100, François Dumont wrote: Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which might be slightly different. I think it is be

Fix move_if_noexcept usages in _Hashtable

2018-12-03 Thread François Dumont
Hi   This patch fix a minor problem with usage of std::move_if_noexcept. We use it to move node content if move construtor is noexcept but we eventually use the allocator_type::construct method which might be slightly different. I think it is better to check for this method noexcept qualifica