Re: Fix odr ICE on Ada LTO

2019-02-12 Thread Richard Biener
On Sun, Feb 10, 2019 at 11:07 PM Jan Hubicka wrote: > > Hi, > I am attaching correct patch. > The option is new only in a relative sense - it was added 5 years ago > with the orinal ODR warning infrastructure. > We have -Wodr-type-merging that controls streming data needed for -Wodr > to work and

Re: Fix odr ICE on Ada LTO

2019-02-10 Thread Jan Hubicka
Hi, I am attaching correct patch. The option is new only in a relative sense - it was added 5 years ago with the orinal ODR warning infrastructure. We have -Wodr-type-merging that controls streming data needed for -Wodr to work and -fno-devirtualize that controls streaming of BINFOs. I was

Re: Fix odr ICE on Ada LTO

2019-02-10 Thread Richard Biener
On February 10, 2019 11:48:01 AM GMT+01:00, Jan Hubicka wrote: >> >> This caused: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89272 > >My apologizes for that. Fixed by the attached patch. This is about ICE >with -fno-lto-odr-type-merging which is option I think we should drop >(probably

Re: Fix odr ICE on Ada LTO

2019-02-10 Thread Jan Hubicka
> > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89272 My apologizes for that. Fixed by the attached patch. This is about ICE with -fno-lto-odr-type-merging which is option I think we should drop (probably next stage1 but if it shows to cause troubles, I would not be against

Re: Fix odr ICE on Ada LTO

2019-02-09 Thread H.J. Lu
On Sat, Feb 9, 2019 at 10:10 AM Jan Hubicka wrote: > > Hi, > this patch fixes ICE in free_lang_data compiling lto8.adb. > The fix is bit symptomatic becuase type_with_linkage_p should return > false for Ada types. Perhaps adding explicit flag to DECL_NAME would > make sense but it can wait for

Fix odr ICE on Ada LTO

2019-02-09 Thread Jan Hubicka
Hi, this patch fixes ICE in free_lang_data compiling lto8.adb. The fix is bit symptomatic becuase type_with_linkage_p should return false for Ada types. Perhaps adding explicit flag to DECL_NAME would make sense but it can wait for next stage1. The fix works because at this stage of