Re: Fix verify_type ICE during Ada bootstrap

2015-11-30 Thread Jan Hubicka
> > I think you are doing too many things in one patch. I'm fine with > dropping the zero-alias-set streaming (but I'd rather not assert > as FE get_alias_set langhook may assign zero to random tree nodes). Ok, the assert was there mostly to double check that all zero alias sets rematerialize

Re: Fix verify_type ICE during Ada bootstrap

2015-11-30 Thread Richard Biener
On Mon, 30 Nov 2015, Jan Hubicka wrote: > Hi, > here is updated patch which bootstraps, lto-bootstraps x86_64-linux > and > also works for Firefox. The basic pain is to identify which calls to > get_alias_set > are used to build alias sets themselves and thus must be made > -fstrict-aliasing >

Re: Fix verify_type ICE during Ada bootstrap

2015-11-29 Thread Jan Hubicka
Hi, here is updated patch which bootstraps, lto-bootstraps x86_64-linux and also works for Firefox. The basic pain is to identify which calls to get_alias_set are used to build alias sets themselves and thus must be made -fstrict-aliasing independent and which are used to drive queries to oracle

Re: Fix verify_type ICE during Ada bootstrap

2015-11-29 Thread Eric Botcazou
> * misc.c (gnat_get_alias_set): Pass true to get_alias_set. > * utils.c (relate_alias_sets): Likewise. > * trans.c (validate_unchecked_conversion): Likewise. Missing gcc-interface/ prefix here. But can't we use a default value (of true I suppose) for the new parameter? --

Re: Fix verify_type ICE during Ada bootstrap

2015-11-29 Thread Jan Hubicka
> > * misc.c (gnat_get_alias_set): Pass true to get_alias_set. > > * utils.c (relate_alias_sets): Likewise. > > * trans.c (validate_unchecked_conversion): Likewise. > > Missing gcc-interface/ prefix here. Updated. > > But can't we use a default value (of true I suppose) for the new

Re: Fix verify_type ICE during Ada bootstrap

2015-11-26 Thread Jan Hubicka
> On Tue, 24 Nov 2015, Jan Hubicka wrote: > > > > > > > > > We do already wrap all bases into MEM_REFs at streaming time, it would > > > > be easy to adjust it to make it effectively alias-set zero. But of > > > > course the overhead and the downstream effects of having more MEM_REFs > > > >

Re: Fix verify_type ICE during Ada bootstrap

2015-11-25 Thread Richard Biener
On Tue, 24 Nov 2015, Jan Hubicka wrote: > > > > > > We do already wrap all bases into MEM_REFs at streaming time, it would > > > be easy to adjust it to make it effectively alias-set zero. But of > > > course the overhead and the downstream effects of having more MEM_REFs > > > (we strip the

Re: Fix verify_type ICE during Ada bootstrap

2015-11-24 Thread Jan Hubicka
> On Tue, 24 Nov 2015, Jan Hubicka wrote: > > > Hi, > > this patch fixes verify_type ICE while building Ada. The problem is that > > we end up with INTEGER_TYPE that has TYPE_ALIAS_SET buts its main variant > > is integer_type_node that is built in LTO and has non-zero alias set. > > > > This

Re: Fix verify_type ICE during Ada bootstrap

2015-11-24 Thread Jan Hubicka
> > > > We do already wrap all bases into MEM_REFs at streaming time, it would > > be easy to adjust it to make it effectively alias-set zero. But of > > course the overhead and the downstream effects of having more MEM_REFs > > (we strip the unneeded ones at stream-in) are unknown (compared to

Fix verify_type ICE during Ada bootstrap

2015-11-24 Thread Jan Hubicka
Hi, this patch fixes verify_type ICE while building Ada. The problem is that we end up with INTEGER_TYPE that has TYPE_ALIAS_SET buts its main variant is integer_type_node that is built in LTO and has non-zero alias set. This is will lead to wrong code if function using integer built with

Re: Fix verify_type ICE during Ada bootstrap

2015-11-24 Thread Richard Biener
On Tue, 24 Nov 2015, Jan Hubicka wrote: > Hi, > this patch fixes verify_type ICE while building Ada. The problem is that > we end up with INTEGER_TYPE that has TYPE_ALIAS_SET buts its main variant > is integer_type_node that is built in LTO and has non-zero alias set. > > This is will lead to