Re: Fold more boolean expressions

2018-10-04 Thread Richard Biener
On Tue, Oct 2, 2018 at 3:38 PM MCC CS wrote: > > Thanks a lot! Well, thank you for the patch (and the patience...)! Richard.

Re: Fold more boolean expressions

2018-10-03 Thread graham stott via gcc-patches
Original message From: MCC CS Date: 02/10/2018 14:38 (GMT+00:00) To: gcc-patches@gcc.gnu.org Subject: Re: Fold more boolean expressions Thanks a lot!

Re: Fold more boolean expressions

2018-10-02 Thread MCC CS
Thanks a lot!

Re: Fold more boolean expressions

2018-10-01 Thread Richard Biener
On Sun, Sep 30, 2018 at 5:11 PM MCC CS wrote: > > > Now that it has got enough reviews and there's > been no comments for a week, I believe > now it's time for us to install it on trunk. > The patch is the same as previous, but rebased > on current trunk. > > Could you please push it for me? If th

Re: Fold more boolean expressions

2018-09-30 Thread MCC CS
Now that it has got enough reviews and there's been no comments for a week, I believe now it's time for us to install it on trunk. The patch is the same as previous, but rebased on current trunk. Could you please push it for me? If there's anything I can do to help, just tell me. 2018-09-30 MCC

Re: Fold more boolean expressions

2018-09-22 Thread MCC CS
Thanks a lot for the review, Richard! - I have updated the patch. - Had done a full "make check" with the second draft. - Did a "make check-gcc" with the final patch. - Both tests have the same tests failing, that always fail: g++.dg/pr80481.C g++.dg/pr83239.C Would be great if anyone willing co

Re: Fold more boolean expressions

2018-09-20 Thread Richard Biener
On Thu, Sep 20, 2018 at 4:00 PM Marc Glisse wrote: > > On Thu, 20 Sep 2018, Richard Biener wrote: > > > On Sat, Sep 15, 2018 at 8:01 AM MCC CS wrote: > >> > >> Sorry for doing the same mistake twice. Is this OK, and do > >> I need to test it again after the first version of this > >> patch? > >>

Re: Fold more boolean expressions

2018-09-20 Thread Marc Glisse
On Thu, 20 Sep 2018, Richard Biener wrote: On Sat, Sep 15, 2018 at 8:01 AM MCC CS wrote: Sorry for doing the same mistake twice. Is this OK, and do I need to test it again after the first version of this patch? 2018-09-15 MCC CS gcc/ PR tree-optimization/87261 * mat

Re: Fold more boolean expressions

2018-09-20 Thread Richard Biener
On Sat, Sep 15, 2018 at 8:01 AM MCC CS wrote: > > Sorry for doing the same mistake twice. Is this OK, and do > I need to test it again after the first version of this > patch? > > 2018-09-15 MCC CS > > gcc/ > PR tree-optimization/87261 > * match.pd: Add boolean optimizatio

Re: Fold more boolean expressions

2018-09-16 Thread MCC CS
Hi, I have bootstrapped and make check'd my final patch on latest trunk. Is it OK? Could you please push it if possible? The patch can be found here, but please update the commit message date: https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00803.html Test result: Native configuration is x86_64-pc

Re: Fold more boolean expressions

2018-09-14 Thread MCC CS
Sorry for doing the same mistake twice. Is this OK, and do I need to test it again after the first version of this patch? 2018-09-15 MCC CS gcc/ PR tree-optimization/87261 * match.pd: Add boolean optimizations, fix whitespace. 2018-09-15 MCC CS gcc/test

Re: Fold more boolean expressions

2018-09-14 Thread Marc Glisse
On Fri, 14 Sep 2018, MCC CS wrote: +/* (~x & y) | ~(x | y) -> ~x */ +(simplify + (bit_ior:c (bit_and:c (bit_not @0) @1) (bit_not (bit_ior:c @0 @1))) + (bit_not @0)) As I said last time, you should not generate a new (bit_not @0) in the output when there is already one in the input. Maybe (s

Re: Fold more boolean expressions

2018-09-14 Thread MCC CS
Thanks for the review! I've cleaned up the :s and :c flags. You can see the changes here: https://www.diffchecker.com/sjNOq5TQ Anyone else have time for another review? Would be really appreciated. 2018-09-14 MCC CS gcc/ PR tree-optimization/87261 * match.pd: Add boolean

Re: Fold more boolean expressions

2018-09-11 Thread Marc Glisse
(just some very quick comments, they may be off, and I haven't looked closely) On Tue, 11 Sep 2018, MCC CS wrote: +/* (~x & y) | ~(x | y) -> ~x */ +(simplify + (bit_ior:c (bit_and:c (bit_not @0) @1) (bit_not (bit_ior:s @0 @1))) + (bit_not @0)) Did you mean :c instead of :s? You should write

Fold more boolean expressions

2018-09-11 Thread MCC CS
Hi everyone, this patch optimizes a few boolean expressions, and fixes some unneeded whitespace. Will do a full make check soon. Thanks for your time. 2018-09-11 MCC CS gcc/ PR tree-optimization/87261 * match.pd: Add boolean optimizations, fix whitespace. 2018