Fortran : Fortran translation issues PR52279

2020-06-24 Thread Mark Eggleston
Patch to fix PR52279.  Marked strings that are indirectly used in error and warning messages so that they are marked for translation. OK to commit? Commit message: Fortran  : Fortran translation issues PR52279 Mark strings for translation by enclosing in G_() and _(). 2020-06-24  Mark

Re: Fortran : Fortran translation issues PR52279

2020-06-30 Thread Mark Eggleston
ping! On 25/06/2020 07:28, Mark Eggleston wrote: Patch to fix PR52279.  Marked strings that are indirectly used in error and warning messages so that they are marked for translation. OK to commit? Commit message: Fortran  : Fortran translation issues PR52279 Mark strings for translation by

Re: Fortran : Fortran translation issues PR52279

2020-06-30 Thread Thomas Koenig
Hi Mark, that one is OK for master. Thanks! Regards Thomas

Re: Fortran : Fortran translation issues PR52279

2020-07-01 Thread Martin Sebor via Gcc-patches
On 6/30/20 6:59 AM, Mark Eggleston wrote: ping! On 25/06/2020 07:28, Mark Eggleston wrote: Patch to fix PR52279.  Marked strings that are indirectly used in error and warning messages so that they are marked for translation. OK to commit? Commit message: Fortran  : Fortran transla

Re: Fortran : Fortran translation issues PR52279

2020-07-01 Thread David Edelsohn via Gcc-patches
This patch breaks bootstrap. It is not portable to use _( ... ) to initialize an array. In file included from /nasfarm/edelsohn/src/src/gcc/fortran/gfortran.h:52, from /nasfarm/edelsohn/src/src/gcc/fortran/check.c:32: /nasfarm/edelsohn/src/src/gcc/fortran/check.c: In function 'bo

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread Mark Eggleston
On 01/07/2020 20:07, David Edelsohn wrote: This patch breaks bootstrap. Apologies. I didn't see this when I built the compiler the with bootstrap on x86_64. I'll endevour to get it fixed as soon as possible. regards, Mark It is not portable to use _( ... ) to initialize an array. In file

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread Mark Eggleston
I've committed the change from array to pointer. Does this fix your builds? On 02/07/2020 08:18, Mark Eggleston wrote: On 01/07/2020 20:07, David Edelsohn wrote: This patch breaks bootstrap. Apologies. I didn't see this when I built the compiler the with bootstrap on x86_64. I'll endevour to

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread David Edelsohn via Gcc-patches
I already had removed your change. I hope that you did not re-break bootstrap. You should be re-producing the breakage and then confirming the fix, not randomly applying patches and asking others if you didn't break it again. That is not appropriate for GCC development. Thanks David On Thu, Ju

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread David Edelsohn via Gcc-patches
On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: > > I've committed the change from array to pointer. Does this fix your builds? > > On 02/07/2020 08:18, Mark Eggleston wrote: > > On 01/07/2020 20:07, David Edelsohn wrote: > >> This patch breaks bootstrap. > > > > Apologies. I didn't see this

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread Mark Eggleston
On 02/07/2020 13:25, David Edelsohn wrote: On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: I've committed the change from array to pointer. Does this fix your builds? On 02/07/2020 08:18, Mark Eggleston wrote: On 01/07/2020 20:07, David Edelsohn wrote: This patch breaks bootstrap. Ap

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread Mark Eggleston
On 02/07/2020 13:56, Mark Eggleston wrote: On 02/07/2020 13:25, David Edelsohn wrote: On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: I've committed the change from array to pointer. Does this fix your builds? On 02/07/2020 08:18, Mark Eggleston wrote: On 01/07/2020 20:07, David Ede

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread David Edelsohn via Gcc-patches
On Thu, Jul 2, 2020 at 8:56 AM Mark Eggleston wrote: > > On 02/07/2020 13:25, David Edelsohn wrote: > > On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston > > wrote: > >> I've committed the change from array to pointer. Does this fix your builds? > >> > >> On 02/07/2020 08:18, Mark Eggleston wrote: >

Re: Fortran : Fortran translation issues PR52279

2020-07-02 Thread David Edelsohn via Gcc-patches
Mark, A quick test with const char hint [] = _(" [see %<-fno-allow-invalid-boz%>]"); reproduces the failure. const char *hint = _(" [see %<-fno-allow-invalid-boz%>]"); seems to work. I will do a full bootstrap test with that change later today. Do you want me to commit it if it works or do y

Re: Fortran : Fortran translation issues PR52279

2020-07-03 Thread David Edelsohn via Gcc-patches
Mark, A full bootstrap is successful with the translation markers restored and declaring hint as "const char *". const char *hint = _(" [see %<-fno-allow-invalid-boz%>]"); I assume that the translation system works correctly for that style. Do you want to apply the patch or do you want me to?