Re: Further refinement to -Wswitch-unreachable

2016-05-31 Thread Jason Merrill
On Tue, May 31, 2016 at 9:40 AM, Marek Polacek wrote: > On Fri, May 27, 2016 at 10:41:51AM -0400, Jason Merrill wrote: >> On 05/26/2016 02:44 PM, Marek Polacek wrote: >> > + if (gimple_code (stmt) == GIMPLE_TRY) >> > { >> > + /* A compiler-generated cleanup or a user-written tr

Re: Further refinement to -Wswitch-unreachable

2016-05-31 Thread Marek Polacek
On Fri, May 27, 2016 at 10:41:51AM -0400, Jason Merrill wrote: > On 05/26/2016 02:44 PM, Marek Polacek wrote: > > + if (gimple_code (stmt) == GIMPLE_TRY) > > { > > + /* A compiler-generated cleanup or a user-written try block. > > +Try to get the first statement in i

Re: Further refinement to -Wswitch-unreachable

2016-05-27 Thread Jason Merrill
On 05/26/2016 02:44 PM, Marek Polacek wrote: + if (gimple_code (stmt) == GIMPLE_TRY) { + /* A compiler-generated cleanup or a user-written try block. +Try to get the first statement in its try-block, for better +location. */ +

Further refinement to -Wswitch-unreachable

2016-05-26 Thread Marek Polacek
Martin complained that -Wswitch-unreachable wouldn't warn on try-blocks, either compiler-generated or user-written. This patch, which looks into GIMPLE_TRY's body, seems to DTRT for both. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2016-05-26 Marek Polacek * gimplify.c (gim