Re: Go patch committed: Rationalize external symbol names

2018-01-25 Thread Ian Lance Taylor
On Thu, Jan 25, 2018 at 12:50 PM, Rainer Orth wrote: > >> From the error messages I guess the problem is that the assembler >> doesn't like symbols that start with ".1". Do you know what names the >> assembler permits? > > The x86 Assembly Language Reference Manual states: Thanks. Looking back,

Re: Go patch committed: Rationalize external symbol names

2018-01-25 Thread Rainer Orth
Hi Ian, > From the error messages I guess the problem is that the assembler > doesn't like symbols that start with ".1". Do you know what names the > assembler permits? The x86 Assembly Language Reference Manual states: 2.1.2.1 Identifiers An identifier is an arbitrarily-long sequence of lette

Re: Go patch committed: Rationalize external symbol names

2018-01-25 Thread Jakub Jelinek
On Thu, Jan 25, 2018 at 12:40:13PM -0800, Ian Lance Taylor wrote: > >> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed > >> to mainline. > > > > this patch almost certainly (i.e. I didn't reghunt, but it's the only > > plausible candidate between r257023 and r257057) Solaris/x8

Re: Go patch committed: Rationalize external symbol names

2018-01-25 Thread Ian Lance Taylor
On Thu, Jan 25, 2018 at 12:28 PM, Rainer Orth wrote: > >> This patch to the Go frontend rationalizes the external symbol names >> that appear in assembler code. It changes from the ad hoc mechanisms >> used to date to produce a set of names that are at least somewhat more >> coherent. They are a

Re: Go patch committed: Rationalize external symbol names

2018-01-25 Thread Rainer Orth
Hi Ian, > This patch to the Go frontend rationalizes the external symbol names > that appear in assembler code. It changes from the ad hoc mechanisms > used to date to produce a set of names that are at least somewhat more > coherent. They are also more readable, after applying a simple > demang

Go patch committed: Rationalize external symbol names

2018-01-24 Thread Ian Lance Taylor
This patch to the Go frontend rationalizes the external symbol names that appear in assembler code. It changes from the ad hoc mechanisms used to date to produce a set of names that are at least somewhat more coherent. They are also more readable, after applying a simple demangling algorithms out