Re: Hashtable comment cleanups & renamings

2019-05-31 Thread Jonathan Wakely
On 27/05/19 22:11 +0200, François Dumont wrote: I had miss some occurences of __bucket_hint to replace with __bucket_count_hint so here is a new version. Ok to commit with the simple ChangeLog entry below ? OK for trunk, thanks.

Re: Hashtable comment cleanups & renamings

2019-05-27 Thread François Dumont
I had miss some occurences of __bucket_hint to replace with __bucket_count_hint so here is a new version. Ok to commit with the simple ChangeLog entry below ? On 5/21/19 7:42 AM, François Dumont wrote: Here is a simplified form.     Rename variables and cleanup comments.     *

Re: Hashtable comment cleanups & renamings

2019-05-20 Thread François Dumont
Here is a simplified form.     Rename variables and cleanup comments.     * include/bits/hashtable_policy.h     * include/bits/hashtable.h Ok to commit ? François On 5/17/19 10:24 PM, Jonathan Wakely wrote: On 17/05/19 18:19 +0200, François Dumont wrote: Hi     I got tired of '__n' being

Re: Hashtable comment cleanups & renamings

2019-05-19 Thread François Dumont
On 5/17/19 10:24 PM, Jonathan Wakely wrote: On 17/05/19 18:19 +0200, François Dumont wrote: Hi     I got tired of '__n' being used in _Hashtable for many different purposes: node, bucket, bucket count, bucket hint. It makes the code difficult to read. This code makes sure that __n is a node

Re: Hashtable comment cleanups & renamings

2019-05-17 Thread Jonathan Wakely
On 17/05/19 18:19 +0200, François Dumont wrote: Hi     I got tired of '__n' being used in _Hashtable for many different purposes: node, bucket, bucket count, bucket hint. It makes the code difficult to read. This code makes sure that __n is a node except is some very limited use cases where

Hashtable comment cleanups & renamings

2019-05-17 Thread François Dumont
Hi     I got tired of '__n' being used in _Hashtable for many different purposes: node, bucket, bucket count, bucket hint. It makes the code difficult to read. This code makes sure that __n is a node except is some very limited use cases where the method name is clear enough to tell what __n