Apologies for the delay. The patch is OK.
Thanks. Committed revision 206875.
Thank you,
Tatiana Udalova
Apologies for the delay. The patch is OK.
On Thu, Jan 16, 2014 at 12:59 AM, Tatiana Udalova t.udal...@samsung.com wrote:
Ping!
Thank you,
Tatiana Udalova
--
Hello,
I have reproduced the problem with mklog mentioned by Jakub:
In my experience mklog is pretty much useless, e.g.
Ping!
Thank you,
Tatiana Udalova
--
Hello,
I have reproduced the problem with mklog mentioned by Jakub:
In my experience mklog is pretty much useless, e.g. if you add a new
function, it will list the previous function as being modified rather
than the new one, etc.
My focus was
Hello,
I have reproduced the problem with mklog mentioned by Jakub:
In my experience mklog is pretty much useless, e.g. if you add a new
function, it will list the previous function as being modified rather
than the new one, etc.
My focus was on functions from headers of diff-log chunks.
I hacked a simple addition to mklog which skips unchanged functions
in diff-log while adding function names to the final ChangeLog.
New mklog results were verified by testsuite which compares reference
ChangeLogs of patches from gcc trunk with logs generated by mklog.
Patched mklog
Diego wrote:
How about this then? Updated mklog now adds 'New file'/'New
test'/'Remove' when necessary.
This is OK. Thanks.
Submitted in r206175.
Let me know if you have ideas on improving the current script. I think
it may make sense to address Jakub's complaint about redundant functions:
Ultimately, mklog ought to write the ChangeLog itself.
We get rid of that headache, at least.
How about this then? Updated mklog now adds 'New file'/'New
test'/'Remove' when necessary.
I did some tests with unified/context-diffed SVN and git and it worked
as expected. I can do more testing
On 20/12/2013, 07:08 , Yury Gribov wrote:
Ultimately, mklog ought to write the ChangeLog itself.
We get rid of that headache, at least.
How about this then? Updated mklog now adds 'New file'/'New
test'/'Remove' when necessary.
I did some tests with unified/context-diffed SVN and git and it
In my experience mklog is pretty much useless, e.g. if you
add a new function, it will list the previous function as being modified
rather than the new one, etc.
In my experience it prints both the old and the new one. If that's a
problem we could probably fix it (I mean I can volunteer).
On 12/19/2013 04:17 PM, Yury Gribov wrote:
In my experience mklog is pretty much useless, e.g. if you
add a new function, it will list the previous function as being modified
rather than the new one, etc.
In my experience it prints both the old and the new one. If that's a
problem we could
On Thu, Dec 19, 2013 at 8:04 AM, Yury Gribov y.gri...@samsung.com wrote:
On 12/19/2013 04:17 PM, Yury Gribov wrote:
In my experience mklog is pretty much useless, e.g. if you
add a new function, it will list the previous function as being modified
rather than the new one, etc.
In my
On 12/19/2013 05:47 PM, Diego Novillo wrote:
The patch is fine (some tweaks below).
If someone volunteers to re-write it in Python,
I think it would make it easier to keep extending.
Frankly in my experience Perl with `use warnings' and `use strict' isn't
that bad. We could just as well
On Thu, Dec 19, 2013 at 9:33 AM, Yury Gribov y.gri...@samsung.com wrote:
Frankly in my experience Perl with `use warnings' and `use strict' isn't
that bad. We could just as well massage existing script.
I suppose.
Got it. Attached new version of script and ChangeLog entry. Will submit
The patch is OK. Feel free to submit now, if you want.
Thanks. Done in r206116.
-Y
14 matches
Mail list logo
