Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-14 Thread Richard Guenther
On Thu, Apr 14, 2011 at 3:34 PM, H.J. Lu hongjiu...@intel.com wrote: We have static unsigned int get_decl_align_unit (tree decl) {  unsigned int align = LOCAL_DECL_ALIGNMENT (decl);  return align / BITS_PER_UNIT; } LOCAL_DECL_ALIGNMENT may increase alignment for local variable.  But it

Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-14 Thread H.J. Lu
On Thu, Apr 14, 2011 at 6:57 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Apr 14, 2011 at 3:34 PM, H.J. Lu hongjiu...@intel.com wrote: We have static unsigned int get_decl_align_unit (tree decl) {  unsigned int align = LOCAL_DECL_ALIGNMENT (decl);  return align /

Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-14 Thread H.J. Lu
On Thu, Apr 14, 2011 at 7:09 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Apr 14, 2011 at 4:01 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Apr 14, 2011 at 6:57 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Apr 14, 2011 at 3:34 PM, H.J. Lu

Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-14 Thread Richard Guenther
On Thu, Apr 14, 2011 at 4:27 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Apr 14, 2011 at 7:09 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Apr 14, 2011 at 4:01 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Apr 14, 2011 at 6:57 AM, Richard Guenther

Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-14 Thread Richard Guenther
On Thu, Apr 14, 2011 at 5:48 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Apr 14, 2011 at 8:26 AM, Michael Matz m...@suse.de wrote: Hi, On Thu, 14 Apr 2011, Richard Guenther wrote: +  if (align DECL_ALIGN (decl)) +    DECL_ALIGN (decl) = align; Shouldn't this unconditionally set