Re: PATCH: Replace tmp with __tmp

2011-09-18 Thread Paolo Carlini
... probably somebody will hate me, but stylistically I also don't understand why the uppercases. Paolo.

Re: PATCH: Replace tmp with __tmp

2011-09-18 Thread Uros Bizjak
On Sat, Sep 17, 2011 at 11:26 PM, H.J. Lu wrote: >>> Agreed. Some parets are missing, though: >>> >>> -  unsigned long long tmp = (__X) ^ (__X - 1); >>> -  return tmp; >>> +  unsigned long long __tmp = (__X) ^ (__X - 1); >>> +  return __tmp; >> >> There is none missing.  This is not a macro. >> >

Re: PATCH: Replace tmp with __tmp

2011-09-17 Thread H.J. Lu
On Sat, Sep 17, 2011 at 3:10 AM, Andreas Schwab wrote: > Uros Bizjak writes: > >> Agreed. Some parets are missing, though: >> >> -  unsigned long long tmp = (__X) ^ (__X - 1); >> -  return tmp; >> +  unsigned long long __tmp = (__X) ^ (__X - 1); >> +  return __tmp; > > There is none missing.  Thi

Re: PATCH: Replace tmp with __tmp

2011-09-17 Thread Andreas Schwab
Uros Bizjak writes: > Agreed. Some parets are missing, though: > > - unsigned long long tmp = (__X) ^ (__X - 1); > - return tmp; > + unsigned long long __tmp = (__X) ^ (__X - 1); > + return __tmp; There is none missing. This is not a macro. Andreas. -- Andreas Schwab, sch...@linux-m68k.o

Re: PATCH: Replace tmp with __tmp

2011-09-17 Thread Uros Bizjak
On Sat, Sep 17, 2011 at 8:31 AM, Andreas Schwab wrote: >> diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h >> index af5d9dc..72ab114 100644 >> --- a/gcc/config/i386/bmiintrin.h >> +++ b/gcc/config/i386/bmiintrin.h >> @@ -42,8 +42,8 @@ __tzcnt_u16 (unsigned short __X) >>  ext

Re: PATCH: Replace tmp with __tmp

2011-09-16 Thread Andreas Schwab
"H.J. Lu" writes: > diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h > index af5d9dc..72ab114 100644 > --- a/gcc/config/i386/bmiintrin.h > +++ b/gcc/config/i386/bmiintrin.h > @@ -42,8 +42,8 @@ __tzcnt_u16 (unsigned short __X) > extern __inline unsigned int __attribute__((__

PATCH: Replace tmp with __tmp

2011-09-16 Thread H.J. Lu
Hi, We should use __tmp instead of tmp in intrinsics. OK for trunk? Thanks. H.J. --- 2011-09-16 H.J. Lu * config/i386/bmiintrin.h: Replace tmp with __tmp. * config/i386/tbmintrin.h: Likewise. diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h index af5d9