Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 01:54 AM, Alan Modra wrote: Before that, fwprop never tries to work on hard registers. I question this claim. It seems to me that fwprop did look at paradoxical subregs of hard regs before my change. That wasn't part of the design anyway. The main purpose of fwprop's

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-05 Thread Richard Sandiford
Paolo Bonzini bonz...@gnu.org writes: On 07/05/2011 01:54 AM, Alan Modra wrote: Before that, fwprop never tries to work on hard registers. I question this claim. It seems to me that fwprop did look at paradoxical subregs of hard regs before my change. That wasn't part of the design

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 10:51 AM, Richard Sandiford wrote: The patch is okay as far as I'm concerned, but I'm not a maintainer of fwprop. You probably should be:-) I'd have no problem with that! Paolo

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread Richard Sandiford
H.J. Lu hongjiu...@intel.com writes: RTL-based forward propagation pass shouldn't propagate hard register. That's seems a bit draconian. Many fixed hard registers ought to be OK. E.g. there doesn't seem to be anything wrong with propagating uses of the stack or frame pointers, subject to the

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread H.J. Lu
On Mon, Jul 4, 2011 at 12:57 PM, Richard Sandiford rdsandif...@googlemail.com wrote: H.J. Lu hongjiu...@intel.com writes: RTL-based forward propagation pass shouldn't propagate hard register. That's seems a bit draconian.  Many fixed hard registers ought to be OK. E.g. there doesn't seem to

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread H.J. Lu
On Mon, Jul 4, 2011 at 1:52 PM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Jul 4, 2011 at 12:57 PM, Richard Sandiford rdsandif...@googlemail.com wrote: H.J. Lu hongjiu...@intel.com writes: RTL-based forward propagation pass shouldn't propagate hard register. That's seems a bit draconian.  

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread Alan Modra
On Mon, Jul 04, 2011 at 01:57:34PM -0700, H.J. Lu wrote: forward_propagate_subreg issue was introduced by http://gcc.gnu.org/ml/gcc-patches/2009-08/msg01203.html Before that, fwprop never tries to work on hard registers. I question this claim. It seems to me that fwprop did look at

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread H.J. Lu
On Mon, Jul 4, 2011 at 4:54 PM, Alan Modra amo...@gmail.com wrote: On Mon, Jul 04, 2011 at 01:57:34PM -0700, H.J. Lu wrote: forward_propagate_subreg issue was introduced by http://gcc.gnu.org/ml/gcc-patches/2009-08/msg01203.html Before that,  fwprop never tries to work on hard registers. I

Re: PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-04 Thread Alan Modra
On Mon, Jul 04, 2011 at 05:09:28PM -0700, H.J. Lu wrote: On Mon, Jul 4, 2011 at 4:54 PM, Alan Modra amo...@gmail.com wrote: I didn't set out to do anything special with hard regs one way or the other, just extended what was already done for paradoxical subregs to sign and zero extended

PATCH [6/n]: Prepare x32: PR rtl-optimization/47449: Don't propagate hard register non-local goto save area

2011-07-03 Thread H.J. Lu
Hi, RTL-based forward propagation pass shouldn't propagate hard register. OK for trunk? Thanks. H.J. --- 2011-06-14 H.J. Lu hongjiu...@intel.com PR rtl-optimization/47449 * fwprop.c (forward_propagate_subreg): Don't propagate hard register nor zero/sign extended hard