Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-25 Thread Fritz Reese
On Tue, Oct 25, 2016 at 11:37 AM Cesar Philippidis wrote: > > On 10/10/2016 08:06 AM, Fritz Reese wrote: > > > --- a/gcc/fortran/intrinsic.texi > > +++ b/gcc/fortran/intrinsic.texi > > @@ -23,6 +23,9 @@ Some basic guidelines for editing this document: > > @end ignore > >

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-25 Thread Cesar Philippidis
On 10/10/2016 08:06 AM, Fritz Reese wrote: > --- a/gcc/fortran/intrinsic.texi > +++ b/gcc/fortran/intrinsic.texi > @@ -23,6 +23,9 @@ Some basic guidelines for editing this document: > @end ignore > > @tex > +\gdef\acosd{\mathop{\rm acosd}\nolimits} > +\gdef\asind{\mathop{\rm asind}\nolimits}

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf > wrote: >> This patch breaks bootstrap: > ... > > Sorry all!! was in a rush to get in the car this morning and made a > hasty commit. Fixed for

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf wrote: > This patch breaks bootstrap: ... Sorry all!! was in a rush to get in the car this morning and made a hasty commit. Fixed for r241001 (sorry Jerry, I was a little too slow.) --- Fritz Reese

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Steve Kargl
On Tue, Oct 11, 2016 at 11:10:13AM -0700, Jerry DeLisle wrote: > @@ -1782,6 +1784,7 @@ radians_f (mpfr_t x, mp_rnd_t rnd_mode) > mpfr_div_d (x, x, 180.0, rnd_mode); > I forgot to point out that the above should changed to mpfr_div_ui (x, x, 180, rnd_mode); In fact, any place where

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Steve Kargl
On Tue, Oct 11, 2016 at 11:10:13AM -0700, Jerry DeLisle wrote: > > diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c > index bf60f747..18135d2f 100644 > --- a/gcc/fortran/simplify.c > +++ b/gcc/fortran/simplify.c > @@ -1768,11 +1768,13 @@ degrees_f (mpfr_t x, mp_rnd_t rnd_mode) >

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Jerry DeLisle
On 10/11/2016 09:32 AM, Aaron Sawdey wrote: > On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: >> On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl ... snip ... > > I think the first part of that cleanup didn't get applied as I am > seeing this: > > ../../gcc/gcc/fortran/iresolve.c: In function

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Andre Vehreschild
Hi all, attached a small patch that resolves the issues at least on x86_64-linux/F23. - Andre On Tue, 11 Oct 2016 11:32:50 -0500 Aaron Sawdey wrote: > On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: > > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > >

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Aaron Sawdey
On Tue, 2016-10-11 at 07:26 -0400, Fritz Reese wrote: > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > wrote: > ... > > > > There are a few small clean-up that can be > > done.  For example, > > > > +static gfc_expr * > > +get_radians (gfc_expr *deg) > > +{ >

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Jerry DeLisle
On 10/11/2016 07:37 AM, Andrew Pinski wrote: > > Looks like it was only broken for some mpfr's. That is ones which is > compiled with gcc it worked but one which comes with Ubuntu 1604 it > does not. they are exactly the same version too. > > Thanks, > Andrew Also broken on Fedora 24. Fritz,

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Andrew Pinski
On Tue, Oct 11, 2016 at 5:43 AM, Markus Trippelsdorf wrote: > On 2016.10.11 at 07:26 -0400, Fritz Reese wrote: >> On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl >> wrote: >> ... >> > There are a few small clean-up that can be >> > done.

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Markus Trippelsdorf
On 2016.10.11 at 07:26 -0400, Fritz Reese wrote: > On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl > wrote: > ... > > There are a few small clean-up that can be > > done. For example, > > > > +static gfc_expr * > > +get_radians (gfc_expr *deg) > > +{ > > + mpfr_t

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl wrote: ... > There are a few small clean-up that can be > done. For example, > > +static gfc_expr * > +get_radians (gfc_expr *deg) > +{ > + mpfr_t tmp; ... > the tmp variable is unneeded in the above. Converting

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-10 Thread Steve Kargl
On Mon, Oct 10, 2016 at 12:29:32PM -0700, Jerry DeLisle wrote: > On 10/10/2016 08:06 AM, Fritz Reese wrote: > > https://gcc.gnu.org/ml/fortran/2016-09/msg00163.html [original] > > https://gcc.gnu.org/ml/fortran/2016-09/msg00183.html [latest] > > > > On Wed, Sep 28, 2016 at 4:14 PM, Fritz Reese

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-10 Thread Jerry DeLisle
On 10/10/2016 08:06 AM, Fritz Reese wrote: > https://gcc.gnu.org/ml/fortran/2016-09/msg00163.html [original] > https://gcc.gnu.org/ml/fortran/2016-09/msg00183.html [latest] > > On Wed, Sep 28, 2016 at 4:14 PM, Fritz Reese wrote: >> Attached is a patch extending the GNU

PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-10 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-09/msg00163.html [original] https://gcc.gnu.org/ml/fortran/2016-09/msg00183.html [latest] On Wed, Sep 28, 2016 at 4:14 PM, Fritz Reese wrote: > Attached is a patch extending the GNU Fortran front-end to support > some additional math