Re: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Richard Sandiford via Gcc-patches
"Roger Sayle" writes: > Hi Richard, >> Yes, which is why I think the target should claim argument passing happens > in reg:HI. > > Unfortunately, this hits another "feature" of the nvptx backend; it's a > > /* Implement TARGET_MODES_TIEABLE_P. */ > bool nvptx_modes_tieable_p (machine_mode,

Re: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Jeff Law via Gcc-patches
On 3/14/2022 2:39 AM, Roger Sayle wrote: The only (other?) possible point of contention is the (arbitrary) decision that when passing floating point values in a larger integer register, the code is hardwired to use zero-extension. This in theory could be turned into a target hook to support

Re: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Jeff Law via Gcc-patches
On 3/14/2022 3:09 AM, Richard Biener wrote: On Mon, 14 Mar 2022, Roger Sayle wrote: I thought I'd add a few comments that might help reviewers of this patch. Most importantly, this patch should be completely safe, as both changes only trigger with FLOAT vs INT size mismatches which

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Richard Biener via Gcc-patches
d. > Cheers, > Roger > -- > > > -Original Message- > > From: Richard Biener > > Sent: 14 March 2022 13:28 > > To: Roger Sayle > > Cc: 'Tom de Vries' ; 'Jeff Law' ; > > 'Tobias Burnus' ; richard.sandif...@arm.com; > 'Jeff > > Law' ; gc

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Roger Sayle
updated as what to > > > > > > do in that eventuality. If they choose to treat these like > > > > > > HImode, they'll run into the same issues, as most ABIs pass > > > > > > HImode in wider word_mode > > > > registers. > > > >

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Richard Biener via Gcc-patches
hard Biener > > Sent: 14 March 2022 10:15 > > To: Roger Sayle > > Cc: 'Tom de Vries' ; 'Jeff Law' ; > > 'Tobias Burnus' ; richard.sandif...@arm.com; > 'Jeff > > Law' ; gcc-patches@gcc.gnu.org > > Subject: RE: PING**4 - [PATCH] middle-end: Support ABIs that pass F

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Roger Sayle
ose there's targets passing SFmode in a SImode GPR and DFmode > > > in a DImode GPR (all soft-float targets?), so that already works somehow. > > > Why does nvptx choose DImode for SFmode passing then? Can't it > > > choose (subreg:SI di:..) or so? Does it require zero-extendin

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Richard Biener via Gcc-patches
Thanks for thinking about this. > Roger > -- > > > -Original Message- > > From: Richard Biener > > Sent: 14 March 2022 09:09 > > To: Roger Sayle > > Cc: 'Tom de Vries' ; 'Jeff Law' ; > > 'Tobias Burnus' ; richard.sandif...@arm.com; > 'Jeff &

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Roger Sayle
rd.sandif...@arm.com; 'Jeff > Law' ; gcc-patches@gcc.gnu.org > Subject: RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as > wider integers. > > On Mon, 14 Mar 2022, Roger Sayle wrote: > > > > > I thought I'd add a few comments that might help revie

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Richard Biener via Gcc-patches
; > > Tobias Burnus > > Cc: richard.sandif...@arm.com; Jeff Law ; gcc- > > patc...@gcc.gnu.org; Roger Sayle > > Subject: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as > > wider integers. > > > > On 3/2/22 20:18, Jeff Law via Gcc-patches wro

RE: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Roger Sayle
> Tobias Burnus > Cc: richard.sandif...@arm.com; Jeff Law ; gcc- > patc...@gcc.gnu.org; Roger Sayle > Subject: PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as > wider integers. > > On 3/2/22 20:18, Jeff Law via Gcc-patches wrote: > > > > > &g

PING**4 - [PATCH] middle-end: Support ABIs that pass FP values as wider integers.

2022-03-14 Thread Tom de Vries via Gcc-patches
On 3/2/22 20:18, Jeff Law via Gcc-patches wrote: On 2/28/2022 5:54 AM, Richard Biener via Gcc-patches wrote: On Mon, 28 Feb 2022, Tobias Burnus wrote: Ping**3 On 23.02.22 09:42, Tobias Burnus wrote: PING**2 for the ME review or at least comments to that patch, which fixes a build