Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-05 Thread Dominique Dhumieres
this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. Since I am stubborn, I have made the test 'dg-do run' and committed the patch as revision r218422. Thanks for the patch, Dominique

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread Andre Vehreschild
Hi, this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. - Andre On Tue, 26 Aug 2014 11:30:12 +0200 Andre Vehreschild ve...@gmx.de wrote: Hi, On Sun, 17 Aug 2014 15:06:02 +0200 Mikael Morin

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread Dominique d'Humières
Le 3 déc. 2014 à 18:08, Andre Vehreschild ve...@gmx.de a écrit : Hi, this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. Not really true, I do have objections, but I won’t fight for them. I

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread FX
this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. I wasn’t back on active duty in August, so I didn’t follow that. But if the only argument for compile-test over run-test is the runtime, then I

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-26 Thread Andre Vehreschild
Hi, On Sun, 17 Aug 2014 15:06:02 +0200 Mikael Morin mikael.mo...@sfr.fr wrote: Le 17/08/2014 14:26, Dominique Dhumieres a écrit : As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html the testcase should check that the code generated is actually working, not just that

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Mikael Morin
Hello, Le 06/08/2014 21:23, Andre Vehreschild a écrit : Hi, [...] *** gcc/fortran/Changelog *** 2014-08-06 Andre Vehreschild ve...@gmx.de PR fortran/60414 * interface.c (compare_parameter): Fixing ICE when argument of a generic is a reference into an array.

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Dominique Dhumieres
As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html the testcase should check that the code generated is actually working, not just that the ICE disappeared. ... thus I think the test should be run, i.e., '! { dg-do compile }' should be replaced with '! { dg-do run }' (I

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Mikael Morin
Le 17/08/2014 14:26, Dominique Dhumieres a écrit : As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html the testcase should check that the code generated is actually working, not just that the ICE disappeared. ... Well, this is for another patch where deferred character

[PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-06 Thread Andre Vehreschild
Hi, thanks for all the input. The issue to patch is an ICE while compiling a call of a generic method using an array reference, e.g., this.Check(vec(1)) where Check aggregates an implementation for an array parameter and one with a scalar parameter. Based on Mikael's input, I analyzed the code

Re: PR 60414: Patch proposal

2014-07-26 Thread Mikael Morin
Hello, thanks for your contribution. here are some comments about the patch: Le 21/07/2014 15:03, Andre Vehreschild a écrit : diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index c33936b..cb01a13 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog Changelogs are

Re: PR 60414: Patch proposal

2014-07-21 Thread Dominique d'Humières
Le 21 juil. 2014 à 15:03, Andre Vehreschild ve...@gmx.de a écrit : Hi Dominique, thank you very much for your comments. I really appreciate them. ;-) Unfortunately I am contracted only for a limited number of around 6 bugs. The control on which bugs to pick is done by compiling a project

Re: PR 60414: Patch proposal

2014-07-19 Thread Andre Vehreschild
Hi FX, thank you for your help: ad 1) I thought the fixes to small for all the trouble to go through with a copyright assignment. But if it is needed, I will happily give copyright to the FSF and negotiate with my client all formal requirements. Unfortunately my English is not well enough to

PR 60414: Patch proposal

2014-07-18 Thread Andre Vehreschild
Hi all, this is my first try to submit a patch, so please be kind and correct me when I do something wrong. I was contracted to fix some issues listed in the bugtracker for fortran. Please find attached my first attempt for bug PR60414 (I'll attach it to the bug in the tracker in a second). The

Re: PR 60414: Patch proposal

2014-07-18 Thread FX
Hi Andre, and welcome aboard! The explanation you give is nice, your patch submission looks clean. Two things: 1. Do you have a copyright assignment on file with the FSF? See https://gcc.gnu.org/contribute.html 2. Normally, all GCC patch submissions should be accompanied by a statement