Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-23 Thread Jonathan Wakely
On 23/08/18 15:29 +0100, Jonathan Wakely wrote: On 23/08/18 08:51 +0100, Jonathan Wakely wrote: On 21/08/18 22:18 +0200, François Dumont wrote: On 21/08/2018 11:33, Jonathan Wakely wrote: On 18/08/18 22:31 +0200, François Dumont wrote: Here is the new proposal. It is indeed possible to keep

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-21 Thread François Dumont
On 21/08/2018 11:33, Jonathan Wakely wrote: On 18/08/18 22:31 +0200, François Dumont wrote: Here is the new proposal. It is indeed possible to keep _Safe_iterator and just add a _Category template parameter to it. While this is still a large patch (obviously, because it's changing a lot!) I

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-21 Thread Jonathan Wakely
On 18/08/18 22:31 +0200, François Dumont wrote: Here is the new proposal. It is indeed possible to keep _Safe_iterator and just add a _Category template parameter to it. While this is still a large patch (obviously, because it's changing a lot!) I think this version is much easier to

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-18 Thread François Dumont
Here is the new proposal. It is indeed possible to keep _Safe_iterator and just add a _Category template parameter to it. I introduce a friend declaration to access container _Base nested typedef from the safe iterator. I review the safe const_iterator constructor from safe iterator. I now

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-07 Thread Jonathan Wakely
On 07/08/18 14:47 +0100, Jonathan Wakely wrote: On 02/08/18 22:16 +0200, François Dumont wrote: Hi     Here is a patch to avoid definition of invalid operators on the Debug mode safe iterator type depending on its category.     Even if it is limited to the Debug mode code I would like to

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-07 Thread Jonathan Wakely
On 02/08/18 22:16 +0200, François Dumont wrote: +#if __cplusplus >= 201103L + /** @brief Copy assignment. */ + _Safe_tagged_iterator& + operator=(const _Safe_tagged_iterator&) = default; + + /** @brief Move assignment. */ + _Safe_tagged_iterator& +

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-07 Thread Jonathan Wakely
On 02/08/18 22:16 +0200, François Dumont wrote: Hi     Here is a patch to avoid definition of invalid operators on the Debug mode safe iterator type depending on its category.     Even if it is limited to the Debug mode code I would like to have a feedback before committing. Especially on

PR libstdc++/68222 Hide safe iterator operators

2018-08-02 Thread François Dumont
Hi     Here is a patch to avoid definition of invalid operators on the Debug mode safe iterator type depending on its category.     Even if it is limited to the Debug mode code I would like to have a feedback before committing. Especially on the following points: - _Safe_tagged_iterator: