Re: PR61140: check the phi is unique in value_replacement

2014-05-12 Thread Jeff Law
On 05/11/14 04:03, Marc Glisse wrote: On Sat, 10 May 2014, Andrew Pinski wrote: On Sat, May 10, 2014 at 3:53 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure

Re: PR61140: check the phi is unique in value_replacement

2014-05-11 Thread Marc Glisse
On Sat, 10 May 2014, Andrew Pinski wrote: On Sat, May 10, 2014 at 3:53 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure how I managed to miss that since I

PR61140: check the phi is unique in value_replacement

2014-05-10 Thread Marc Glisse
Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure how I managed to miss that since I copy-pasted the line just below the test). If there are other phi nodes (with different arguments for those 2

Re: PR61140: check the phi is unique in value_replacement

2014-05-10 Thread Andrew Pinski
On Sat, May 10, 2014 at 3:53 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure how I managed to miss that since I copy-pasted the line just below the test).