Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-21 Thread Segher Boessenkool
On Wed, May 19, 2021 at 09:39:30PM +0930, Alan Modra wrote: > On Tue, May 18, 2021 at 05:48:40AM -0500, Segher Boessenkool wrote: > > I wrote a bit later: > > > > > > Can you make this less hacky please? Changing the generic code is just > > > > fine as well, it needs some love. > > > > In

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-19 Thread Alan Modra via Gcc-patches
On Tue, May 18, 2021 at 05:48:40AM -0500, Segher Boessenkool wrote: > I wrote a bit later: > > > > Can you make this less hacky please? Changing the generic code is just > > > fine as well, it needs some love. > > In effect making a callback / hook without making that explicit is bad > for

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-18 Thread Segher Boessenkool
Hi! On Tue, May 18, 2021 at 07:43:49PM +0930, Alan Modra wrote: > On Mon, May 10, 2021 at 04:39:55PM -0500, Segher Boessenkool wrote: > > Huh, did it not already do that?! Hrm, all the other hooks seem to be > > called via rs6000.c currently. But you do the same, so why do you need > > to

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-18 Thread Alan Modra via Gcc-patches
On Mon, May 10, 2021 at 04:39:55PM -0500, Segher Boessenkool wrote: > Hi! > > On Fri, May 07, 2021 at 12:19:52PM +0930, Alan Modra wrote: > > PowerPC64 ELFv2 dual entry point functions have a couple of problems > > with -fpatchable-function-entry. One is that the nops added after the > > global

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-10 Thread Segher Boessenkool
Hi! On Fri, May 07, 2021 at 12:19:52PM +0930, Alan Modra wrote: > PowerPC64 ELFv2 dual entry point functions have a couple of problems > with -fpatchable-function-entry. One is that the nops added after the > global entry land in the global entry code which is constrained to be > a power of two

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-07 Thread will schmidt via Gcc-patches
On Fri, 2021-05-07 at 12:19 +0930, Alan Modra via Gcc-patches wrote: > PowerPC64 ELFv2 dual entry point functions have a couple of problems > with -fpatchable-function-entry. One is that the nops added after the > global entry land in the global entry code which is constrained to be > a power of

PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-06 Thread Alan Modra via Gcc-patches
PowerPC64 ELFv2 dual entry point functions have a couple of problems with -fpatchable-function-entry. One is that the nops added after the global entry land in the global entry code which is constrained to be a power of two number of instructions, and zero global entry code has special meaning