Properly handle C2x attributes on types

2019-11-21 Thread Joseph Myers
attribs.c has code to ignore all scoped attributes appertaining to types except when they are part of the definition of that type. I think the premise of that code is incorrect, and its presence is a bug; such attributes are clearly valid in both C and C++, which explicitly specify that attributes

Re: Properly handle C2x attributes on types

2019-11-23 Thread Jeff Law
On 11/21/19 7:42 PM, Joseph Myers wrote: > attribs.c has code to ignore all scoped attributes appertaining to > types except when they are part of the definition of that type. > > I think the premise of that code is incorrect, and its presence is a > bug; such attributes are clearly valid in both

Re: Properly handle C2x attributes on types

2019-11-25 Thread Rainer Orth
Hi Joseph, > attribs.c has code to ignore all scoped attributes appertaining to > types except when they are part of the definition of that type. > > I think the premise of that code is incorrect, and its presence is a > bug; such attributes are clearly valid in both C and C++, which > explicitly

Re: Properly handle C2x attributes on types

2019-11-25 Thread Joseph Myers
On Mon, 25 Nov 2019, Rainer Orth wrote: > it seems you missed updating a couple of testcases that are ia32-only: I think it's unavoidable that such target-specific testcases need updating by someone testing on the target in question. -- Joseph S. Myers jos...@codesourcery.com

Re: Properly handle C2x attributes on types

2019-11-27 Thread Rainer Orth
Hi Joseph, > On Mon, 25 Nov 2019, Rainer Orth wrote: > >> it seems you missed updating a couple of testcases that are ia32-only: > > I think it's unavoidable that such target-specific testcases need updating > by someone testing on the target in question. like so? Tested on i386-pc-solaris2.11.

Re: Properly handle C2x attributes on types

2019-12-07 Thread Jeff Law
On Wed, 2019-11-27 at 12:23 +0100, Rainer Orth wrote: > Hi Joseph, > > > On Mon, 25 Nov 2019, Rainer Orth wrote: > > > > > it seems you missed updating a couple of testcases that are ia32- > > > only: > > > > I think it's unavoidable that such target-specific testcases need > > updating > > by