Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-07 Thread DJ Delorie
"REIX, Tony" writes: > It appears that XNEWVEC() calls xmalloc which prints a message and > calls xexit if malloc fails. Objection removed then ;-) > So, yes, we check if (strtab == NULL) though there is no way that > XDELETEVEC(NULL) breaks something. However, it is a classic > programming st

Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-07 Thread David Edelsohn
On Wed, Jun 7, 2017 at 10:22 AM, REIX, Tony wrote: > Hi David, > > I'll fix the code incorrectly indented. I already have fixed the indentation in my copy. > > About your comment about our code looking for TEXT section by looking at > string ".text" , please note that our patch fixes a file ca

RE:[PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-07 Thread REIX, Tony
es - France www.atos.net De : David Edelsohn [dje@gmail.com] Envoyé : mercredi 7 juin 2017 01:25 À : REIX, Tony; Ian Taylor Cc : SARTER, MATTHIEU (ext); GCC Patches Objet : Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF Tony, This patch generally look

RE:[PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-07 Thread REIX, Tony
_ De : DJ Delorie [d...@redhat.com] Envoyé : mercredi 7 juin 2017 01:52 À : David Edelsohn Cc : REIX, Tony; i...@golang.org; SARTER, MATTHIEU (ext); gcc-patches@gcc.gnu.org Objet : Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF David Edelsohn writes: > This patch generally looks good

Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-06 Thread DJ Delorie
David Edelsohn writes: > This patch generally looks good to me -- it clearly is an incremental > improvement. One of the libiberty maintainers, such as Ian, needs to > approve the patch. As AIX maintainer, I think you have the authority to approve patches like this, which only affect your OS.

Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF

2017-06-06 Thread David Edelsohn
Tony, This patch generally looks good to me -- it clearly is an incremental improvement. One of the libiberty maintainers, such as Ian, needs to approve the patch. https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01181.html + if (strcmp (name, ".text") == 0) +textptr = scnptr; The ab