On Wed, Oct 29, 2014 at 04:05:27PM +, Zamyatin, Igor wrote:
The question remains, are the decls all you need from the traversal (i.e.
what you need to act upon)? From my earlier skim of the original code that
wasn't that obvious.
You can have in decl_map at least also BLOCKs,
The question remains, are the decls all you need from the traversal (i.e.
what you need to act upon)? From my earlier skim of the original code that
wasn't that obvious.
You can have in decl_map at least also BLOCKs, perhaps types too, what
else?
Jakub,
Seems the BLOCKs are the only
On Thu, Oct 16, 2014 at 11:06:34AM -0600, Jeff Law wrote:
We really prefer fully specified sorts. For a qsort callback, this
doesn't look fully specified.
With that fixed, this should be OK.
jeff
Thanks for the review. Here is the updated version.
Is it ok?
Yes, this is good for
For some reasons it passed bootstrap locally...
-Original Message-
From: Jakub Jelinek [mailto:ja...@redhat.com]
Sent: Tuesday, October 21, 2014 12:15 PM
To: Zamyatin, Igor; Jeff Law
Cc: GCC Patches (gcc-patches@gcc.gnu.org)
Subject: Re: [PATCH, PR63307] Fix generation of new
On Tue, Oct 21, 2014 at 10:14:56AM +0200, Jakub Jelinek wrote:
I've bootstrapped/regtested on i686-linux the following quick fix,
bootstrapped on x86_64-linux too, in the middle of regtesting there.
If it succeeds, I'll commit as obvious, so that people can continue working
on the trunk.
Ah,
c-family/Changelog:
2014-10-03 Igor Zamyatin igor.zamya...@intel.com
PR c/63307
* cilk.c: Include vec.h.
(struct cilk_decls): New structure.
(wrapper_parm_cb): Split this function to...
(fill_decls_vec): ...this...
(create_parm_list): ...and this.
On 10/16/14 09:16, Zamyatin, Igor wrote:
c-family/Changelog:
2014-10-03 Igor Zamyatin igor.zamya...@intel.com
PR c/63307
* cilk.c: Include vec.h.
(struct cilk_decls): New structure.
(wrapper_parm_cb): Split this function to...
(fill_decls_vec):
On 10/04/14 05:54, Zamyatin, Igor wrote:
Hi!
The following patch does fix random order for new decls generation during
Cilk_spawn generation.
As Jakub suggested in the PR first we deal with vectors, then sort them and
only then perform necessary generation of new decls.
Bootstrapped and
