RE: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-25 Thread Tamar Christina
, 2018 18:03 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; James Greenhalgh > ; Richard Earnshaw > ; Marcus Shawcroft > > Subject: Re: [PATCH][GCC][AArch64] Updated stack-clash implementation > supporting 64k probes. [patch (1/6)] > > On 07/16/2018 07:54 AM,

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-08-03 Thread Jeff Law
On 07/25/2018 05:09 AM, Tamar Christina wrote: > Hi All, > > Attached is an updated patch that clarifies some of the comments in the patch > and adds comments to the individual testcases > as requested. > > Ok for trunk? > > Thanks, > Tamar > > gcc/ > 2018-07-25 Jeff Law > Richard

RE: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-08-07 Thread Tamar Christina
ar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; James Greenhalgh > ; Richard Earnshaw > ; Marcus Shawcroft > > Subject: Re: [PATCH][GCC][AArch64] Updated stack-clash implementation > supporting 64k probes. [patch (1/6)] > > On 07/25/2018 05:09 AM, Tamar Christina wrote

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-11 Thread Jeff Law
On 07/11/2018 05:20 AM, Tamar Christina wrote: > Hi All, > > This patch implements the use of the stack clash mitigation for aarch64. > In Aarch64 we expect both the probing interval and the guard size to be 64KB > and we enforce them to always be equal. > > We also probe up by 1024 bytes in the

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-11 Thread Jeff Law
On 07/11/2018 05:20 AM, Tamar Christina wrote: > Hi All, > > This patch implements the use of the stack clash mitigation for aarch64. > In Aarch64 we expect both the probing interval and the guard size to be 64KB > and we enforce them to always be equal. > > We also probe up by 1024 bytes in the

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-12 Thread Tamar Christina
Hi Jeff, Thanks for the review! The 07/11/2018 18:30, Jeff Law wrote: > On 07/11/2018 05:20 AM, Tamar Christina wrote: > > Hi All, > > > > This patch implements the use of the stack clash mitigation for aarch64. > > In Aarch64 we expect both the probing interval and the guard size to be 64KB > >

RE: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-13 Thread Tamar Christina
hristina > Sent: Thursday, July 12, 2018 18:40 > To: Jeff Law > Cc: gcc-patches@gcc.gnu.org; nd ; James Greenhalgh > ; Richard Earnshaw > ; Marcus Shawcroft > > Subject: Re: [PATCH][GCC][AArch64] Updated stack-clash implementation > supporting 64k probes. [patch (1/6)]

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-13 Thread Jeff Law
On 07/12/2018 11:39 AM, Tamar Christina wrote: >>> + >>> + /* Round size to the nearest multiple of guard_size, and calculate the >>> + residual as the difference between the original size and the rounded >>> + size. */ >>> + HOST_WIDE_INT rounded_size = size & -guard_size; >>> + HOST_WI

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-16 Thread Tamar Christina
The 07/13/2018 17:46, Jeff Law wrote: > On 07/12/2018 11:39 AM, Tamar Christina wrote: > >>> + > >>> + /* Round size to the nearest multiple of guard_size, and calculate the > >>> + residual as the difference between the original size and the rounded > >>> + size. */ > >>> + HOST_WIDE_INT

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]

2018-07-16 Thread Jeff Law
On 07/16/2018 07:54 AM, Tamar Christina wrote: > The 07/13/2018 17:46, Jeff Law wrote: >> On 07/12/2018 11:39 AM, Tamar Christina wrote: > + > + /* Round size to the nearest multiple of guard_size, and calculate the > + residual as the difference between the original size and the r